Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 1407703003: Reland: Use GpuMemoryBufferVideoFramePool for WebMediaPlayerMS and MediaStreamVideoRendererSink (Closed)

Created:
5 years, 2 months ago by emircan
Modified:
5 years, 2 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, creis+watch_chromium.org, imcheng+watch_chromium.org, posciak+watch_chromium.org, jasonroberts+watch_google.com, nasko+codewatch_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mlamouri+watch-test-runner_chromium.org, mkwst+moarreviews-shell_chromium.org, mkwst+moarreviews-renderer_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, jochen+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Use GpuMemoryBufferVideoFramePool for WebMediaPlayerMS and MediaStreamVideoRendererSink Relanding after expanding a DCHECK on CopyFrameToYV12() of wedmediaplayer_ms.cc TBR=dcastagna@chromium.org, phoglund@chromium.org, mcasas@chromium.org, sievers@chromium.org, xhwang@chromium.org, rationale: this patch is equivalent to the already LGTMd Original description --------------------------------------------------- Use GpuMemoryBufferVideoFramePool for WebMediaPlayerMS and MediaStreamVideoRendererSink MediaStreamVideoRendererSink is the common sink for video playback where we receive both the local camera capture frame and all the remote capture frames from peer connections. They are all hooked to the MediaStream elements. This CL follows dcastagna's CL that applies asynchronous copies to WebMediaPlayerimpl [0]. [0] https://codereview.chromium.org/1273943002/ BUG=440843, 503835 TEST= On Linux: - With and Without the kUseGpuMemoryBuffersForCapture flag, AppRTC loopback runs as expected. - With and Without the kEnableGpuMemoryBufferVideoFrames flag, AppRTC loopback runs as expected Committed: https://crrev.com/d49c3945570e7eff2ce728927f8c9fecd04f3487 Cr-Commit-Position: refs/heads/master@{#353839} patch from issue 1358883003 at patchset 310001 (http://crrev.com/1358883003#ps310001) Committed: https://crrev.com/c1463d52f046f20244ac7c2d571c7578ff686105 Cr-Commit-Position: refs/heads/master@{#354087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -54 lines) Patch
M content/public/renderer/media_stream_renderer_factory.h View 2 chunks +14 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_renderer_factory_impl.h View 1 chunk +5 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_renderer_factory_impl.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M content/renderer/media/media_stream_video_renderer_sink.h View 4 chunks +23 lines, -4 lines 0 comments Download
M content/renderer/media/media_stream_video_renderer_sink.cc View 4 chunks +39 lines, -6 lines 0 comments Download
M content/renderer/media/media_stream_video_renderer_sink_unittest.cc View 4 chunks +38 lines, -2 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 3 chunks +14 lines, -7 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 4 chunks +14 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +9 lines, -5 lines 0 comments Download
M content/shell/renderer/layout_test/test_media_stream_renderer_factory.h View 1 chunk +5 lines, -1 line 0 comments Download
M content/shell/renderer/layout_test/test_media_stream_renderer_factory.cc View 1 chunk +5 lines, -1 line 0 comments Download
M content/test/data/media/getusermedia.html View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/media/webrtc_test_utilities.js View 2 chunks +8 lines, -1 line 0 comments Download
M media/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M media/media.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A media/renderers/mock_gpu_memory_buffer_video_frame_pool.h View 1 chunk +26 lines, -0 lines 0 comments Download
A media/renderers/mock_gpu_memory_buffer_video_frame_pool.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M media/renderers/video_renderer_impl_unittest.cc View 2 chunks +1 line, -15 lines 0 comments Download
M media/video/gpu_memory_buffer_video_frame_pool.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407703003/1
5 years, 2 months ago (2015-10-14 18:28:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 19:47:50 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 19:48:43 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1463d52f046f20244ac7c2d571c7578ff686105
Cr-Commit-Position: refs/heads/master@{#354087}

Powered by Google App Engine
This is Rietveld 408576698