Issue 14077010: Move ash tray audio UI code from ash/system/audio to ash/system/chromeos/audio.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14077010: Move ash tray audio UI code from ash/system/audio to ash/system/chromeos/audio. (Closed)

Created:
7 years, 8 months ago by jennyz

Modified:
7 years, 8 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move ash tray audio UI code from ash/system/audio to ash/system/chromeos/audio. BUG=160311 TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194429

Patch Set 1 #

Patch Set 2 : Make audio code CHROMROS only in SystemTrayNotifier. #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -404 lines)			Patch
M	ash/ash.gyp	View		2 chunks	+3 lines, -3 lines	0 comments	Download
D	ash/system/audio/audio_observer.h	View		1 chunk	+0 lines, -22 lines	0 comments	Download
D	ash/system/audio/tray_volume.h	View		1 chunk	+0 lines, -53 lines	0 comments	Download
D	ash/system/audio/tray_volume.cc	View		1 chunk	+0 lines, -288 lines	0 comments	Download
A +	ash/system/chromeos/audio/audio_observer.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ash/system/chromeos/audio/tray_volume.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	ash/system/chromeos/audio/tray_volume.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ash/system/tray/system_tray.cc	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	ash/system/tray/system_tray_notifier.h	View	1	8 chunks	+7 lines, -7 lines	0 comments	Download
M	ash/system/tray/system_tray_notifier.cc	View	1	4 chunks	+21 lines, -20 lines	0 comments	Download
M	chrome/browser/chromeos/system/ash_system_tray_delegate.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jennyz

This cl is a preparation cl for the later cls for switching UI code to ...

7 years, 8 months ago (2013-04-15 22:42:29 UTC) #1

jennyz

7 years, 8 months ago (2013-04-16 20:05:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r194429 (presubmit successful).

Expand Messages | Collapse Messages