third_party/WebKit/Source/web/WebPageSerializerImpl.cpp - Issue 1407663004: Tweaking WebPageSerializerImpl to emit a BOM for UTF16/32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPageSerializerImpl.cpp

Issue 1407663004: Tweaking WebPageSerializerImpl to emit a BOM for UTF16/32. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Using TextEncoding::isNonByteBasedEncoding instead. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/save_page_browsertest.cc ('K') | « chrome/test/data/save_page/frames-encodings.htm ('k') | third_party/WebKit/Source/wtf/text/TextEncoding.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebPageSerializerImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebPageSerializerImpl.cpp b/third_party/WebKit/Source/web/WebPageSerializerImpl.cpp

index 694c823537fd26515f275bd1652c7d9b25ae848e..5a5d293601413f3bf543a906abb61ee7603587a6 100644

--- a/third_party/WebKit/Source/web/WebPageSerializerImpl.cpp

+++ b/third_party/WebKit/Source/web/WebPageSerializerImpl.cpp

@@ -453,6 +453,10 @@ bool WebPageSerializerImpl::serialize()

didSerialization = true;

const WTF::TextEncoding& textEncoding = document->encoding().isValid() ? document->encoding() : UTF8Encoding();

+ if (textEncoding.isNonByteBasedEncoding()) {

+ const UChar bomCharacter = 0xFEFF;

jsbell 2015/12/08 01:19:07 nit: maybe call this `byteOrderMark` as it's not t

Łukasz Anforowicz 2015/12/09 00:50:59 Done.

+ m_dataBuffer.append(bomCharacter);

+ }

SerializeDomParam param(url, textEncoding, document, m_localDirectoryName);