third_party/WebKit/Source/web/WebPageSerializerImpl.h - Issue 1407663004: Tweaking WebPageSerializerImpl to emit a BOM for UTF16/32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPageSerializerImpl.h

Issue 1407663004: Tweaking WebPageSerializerImpl to emit a BOM for UTF16/32. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Saving UTF16 with BOM. Leaving UTF32 in a broken state. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/save_page/frames-encodings.htm ('k') | third_party/WebKit/Source/web/WebPageSerializerImpl.cpp » ('j') | third_party/WebKit/Source/web/WebPageSerializerImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebPageSerializerImpl.h

diff --git a/third_party/WebKit/Source/web/WebPageSerializerImpl.h b/third_party/WebKit/Source/web/WebPageSerializerImpl.h

index fd20800b908a627f21f21f28e2149e1e6466c145..9376cdd32e46521d8d465d61d99f269d1929fad2 100644

--- a/third_party/WebKit/Source/web/WebPageSerializerImpl.h

+++ b/third_party/WebKit/Source/web/WebPageSerializerImpl.h

@@ -102,6 +102,9 @@ private:

// Local directory name of all local resource files.

WTF::String m_localDirectoryName;

+ // Tracks whether we've encoded any bytes yet.

+ bool m_noBytesEncodedYet;

jsbell 2015/12/07 22:53:51 Can you flip the semantics of this so that it star

// Web entities conversion maps.

WebEntities m_htmlEntities;

WebEntities m_xmlEntities;