Some plumbing for the beginning of getting handles into snapshot/minidump

util/win/process_info.h

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 122 matching lines @@
   //!     of ranges, representing the readable portions of the original range.
   //!
   //! \param[in] range The range being identified.
   //!
   //! \return A vector of ranges corresponding to the portion of \a range that
   //!     is readable based on the memory map.
   std::vector<CheckedRange<WinVMAddress, WinVMSize>> GetReadableRanges(
       const CheckedRange<WinVMAddress, WinVMSize>& range) const;
 
   //! \brief Retrieves information about open handles in the target process.
-  const std::vector<Handle>& Handles();
+  const std::vector<Handle>& Handles() const;
 
  private:
   template <class Traits>
   friend bool GetProcessBasicInformation(HANDLE process,
                                          bool is_wow64,
                                          ProcessInfo* process_info,
                                          WinVMAddress* peb_address,
                                          WinVMSize* peb_size);
   template <class Traits>
   friend bool ReadProcessData(HANDLE process,
                               WinVMAddress peb_address_vmaddr,
                               ProcessInfo* process_info);
 
   friend bool ReadMemoryInfo(HANDLE process,
                              bool is_64_bit,
                              ProcessInfo* process_info);
 
   std::vector<Handle> BuildHandleVector(HANDLE process) const;
 
   pid_t process_id_;
   pid_t inherited_from_process_id_;
   HANDLE process_;
   std::wstring command_line_;
   WinVMAddress peb_address_;
   WinVMSize peb_size_;
   std::vector<Module> modules_;
   std::vector<MEMORY_BASIC_INFORMATION64> memory_info_;
-  std::vector<Handle> handles_;
+
+  // Handles() is logically const, but updates this member on first retrieval.
+  // See https://code.google.com/p/crashpad/issues/detail?id=9.
+  mutable std::vector<Handle> handles_;
+
   bool is_64_bit_;
   bool is_wow64_;
   InitializationStateDcheck initialized_;
 
   DISALLOW_COPY_AND_ASSIGN(ProcessInfo);
 };
 
 //! \brief Given a memory map of a process, and a range to be read from the
 //!     target process, returns a vector of ranges, representing the readable
 //!     portions of the original range.
 //!
 //! This is a free function for testing, but prefer
 //! ProcessInfo::GetReadableRanges().
 std::vector<CheckedRange<WinVMAddress, WinVMSize>> GetReadableRangesOfMemoryMap(
     const CheckedRange<WinVMAddress, WinVMSize>& range,
     const std::vector<MEMORY_BASIC_INFORMATION64>& memory_info);
 
 }  // namespace crashpad
 
 #endif  // CRASHPAD_UTIL_WIN_PROCESS_INFO_H_