Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: snapshot/minidump/process_snapshot_minidump.cc

Issue 1407643004: Some plumbing for the beginning of getting handles into snapshot/minidump (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@handles-redux
Patch Set: . Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « snapshot/minidump/process_snapshot_minidump.h ('k') | snapshot/process_snapshot.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Crashpad Authors. All rights reserved. 1 // Copyright 2015 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 return nullptr; 177 return nullptr;
178 } 178 }
179 179
180 std::vector<const MemoryMapRegionSnapshot*> ProcessSnapshotMinidump::MemoryMap() 180 std::vector<const MemoryMapRegionSnapshot*> ProcessSnapshotMinidump::MemoryMap()
181 const { 181 const {
182 INITIALIZATION_STATE_DCHECK_VALID(initialized_); 182 INITIALIZATION_STATE_DCHECK_VALID(initialized_);
183 NOTREACHED(); // https://code.google.com/p/crashpad/issues/detail?id=10 183 NOTREACHED(); // https://code.google.com/p/crashpad/issues/detail?id=10
184 return std::vector<const MemoryMapRegionSnapshot*>(); 184 return std::vector<const MemoryMapRegionSnapshot*>();
185 } 185 }
186 186
187 std::vector<HandleSnapshot> ProcessSnapshotMinidump::Handles() const {
188 INITIALIZATION_STATE_DCHECK_VALID(initialized_);
189 NOTREACHED(); // https://code.google.com/p/crashpad/issues/detail?id=10
190 return std::vector<HandleSnapshot>();
191 }
192
187 std::vector<const MemorySnapshot*> ProcessSnapshotMinidump::ExtraMemory() 193 std::vector<const MemorySnapshot*> ProcessSnapshotMinidump::ExtraMemory()
188 const { 194 const {
189 INITIALIZATION_STATE_DCHECK_VALID(initialized_); 195 INITIALIZATION_STATE_DCHECK_VALID(initialized_);
190 NOTREACHED(); // https://code.google.com/p/crashpad/issues/detail?id=10 196 NOTREACHED(); // https://code.google.com/p/crashpad/issues/detail?id=10
191 return std::vector<const MemorySnapshot*>(); 197 return std::vector<const MemorySnapshot*>();
192 } 198 }
193 199
194 bool ProcessSnapshotMinidump::InitializeCrashpadInfo() { 200 bool ProcessSnapshotMinidump::InitializeCrashpadInfo() {
195 const auto& stream_it = stream_map_.find(kMinidumpStreamTypeCrashpadInfo); 201 const auto& stream_it = stream_map_.find(kMinidumpStreamTypeCrashpadInfo);
196 if (stream_it == stream_map_.end()) { 202 if (stream_it == stream_map_.end()) {
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
331 << "duplicate module_crashpad_info_list minidump_module_list_index " 337 << "duplicate module_crashpad_info_list minidump_module_list_index "
332 << minidump_link.minidump_module_list_index; 338 << minidump_link.minidump_module_list_index;
333 return false; 339 return false;
334 } 340 }
335 } 341 }
336 342
337 return true; 343 return true;
338 } 344 }
339 345
340 } // namespace crashpad 346 } // namespace crashpad
OLDNEW
« no previous file with comments | « snapshot/minidump/process_snapshot_minidump.h ('k') | snapshot/process_snapshot.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698