Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2237)

Unified Diff: content/test/gpu/gpu_tests/test_expectations.py

Issue 1407643003: Fix WebGL 2.0 expectations and skip a test with an assertion failure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/test/gpu/gpu_tests/test_expectations_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/gpu/gpu_tests/test_expectations.py
diff --git a/content/test/gpu/gpu_tests/test_expectations.py b/content/test/gpu/gpu_tests/test_expectations.py
index 501ee005664b2919c5a0f996c59cf0c8a2fc2004..9879e9f794cad64e8165ac48b09d8b4ed3681711 100644
--- a/content/test/gpu/gpu_tests/test_expectations.py
+++ b/content/test/gpu/gpu_tests/test_expectations.py
@@ -165,6 +165,11 @@ class TestExpectations(object):
# assume that.
if (url_path and url_path[0] == '/'):
url_path = url_path[1:]
+ # Python's urlsplit doesn't seem to handle query arguments for
+ # file:// URLs properly. Split them off manually.
+ query_index = url_path.find('?')
+ if query_index > 0:
+ url_path = url_path[0:query_index]
return url_path
def _GetExpectationObjectForPage(self, browser, page):
« no previous file with comments | « no previous file | content/test/gpu/gpu_tests/test_expectations_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698