Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1407643003: Fix WebGL 2.0 expectations and skip a test with an assertion failure. (Closed)

Created:
5 years, 2 months ago by Ken Russell (switch to Gerrit)
Modified:
5 years, 2 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, bajones, Jamie Madill, Corentin Wallez, Geoff Lang, nednguyen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix WebGL 2.0 expectations and skip a test with an assertion failure. Query arguments weren't being stripped from file:// URLs by Python's urlparse.urlsplit, which seems to have caused all WebGL 2.0 suppressions for specific pages to be ignored, instead taking any wildcard suppressions for that platform or configuration. Fixed this and added a unit test. BUG=542901 TBR=zmo@chromium.org Committed: https://crrev.com/f3e8c3fb1bf76ffb386034e3f6c8aee8e1bb3f07 Cr-Commit-Position: refs/heads/master@{#353933}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M content/test/gpu/gpu_tests/test_expectations.py View 1 chunk +5 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/test_expectations_unittest.py View 1 chunk +6 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ken Russell (switch to Gerrit)
All: I'm CQ'ing this TBR'd to fix the Windows Debug bots on the FYI waterfall. ...
5 years, 2 months ago (2015-10-14 00:01:28 UTC) #2
Ken Russell (switch to Gerrit)
+Ned as FYI. Slight chance that this query argument nastiness might affect other parts of ...
5 years, 2 months ago (2015-10-14 00:03:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407643003/1
5 years, 2 months ago (2015-10-14 00:04:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 01:12:24 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 01:13:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3e8c3fb1bf76ffb386034e3f6c8aee8e1bb3f07
Cr-Commit-Position: refs/heads/master@{#353933}

Powered by Google App Engine
This is Rietveld 408576698