Add a UMA stat to track if the Browser blacklist is Set on the Renderer

content/renderer/renderer_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
 #include "base/debug/debugger.h"
 #include "base/debug/stack_trace.h"
 #include "base/debug/trace_event.h"
 #include "base/i18n/rtl.h"
@@ skipping 30 matching lines @@
 #if defined(OS_MACOSX)
 #include <Carbon/Carbon.h>
 #include <signal.h>
 #include <unistd.h>
 
 #include "base/mac/mac_util.h"
 #include "base/mac/scoped_nsautorelease_pool.h"
 #include "third_party/WebKit/public/web/WebView.h"
 #endif  // OS_MACOSX
 
+#if defined(OS_WIN)
+#include "chrome_elf/blacklist/blacklist.h"
+#endif  // OS_WIN
+
 #if defined(ENABLE_WEBRTC)
 #include "third_party/libjingle/overrides/init_webrtc.h"
 #endif
 
 namespace content {
 namespace {
 // This function provides some ways to test crash and assertion handling
 // behavior of the renderer.
 static void HandleRendererErrorTestParameters(const CommandLine& command_line) {
   if (command_line.HasSwitch(switches::kWaitForDebugger))
@@ skipping 169 matching lines @@
     }
 #if defined(OS_POSIX) && !defined(OS_MACOSX)
     RenderProcessImpl render_process;
     new RenderThreadImpl();
 #endif
 
     base::HighResolutionTimerManager hi_res_timer_manager;
 
     platform.RunSandboxTests(no_sandbox);
 
+#if defined(OS_WIN)
+    // TODO(csharp): Remove once the renderer is no longer getting
+    // patched this way.
+    if (blacklist::IsBlacklistInitialized())
+      UMA_HISTOGRAM_BOOLEAN("Blacklist.PatchedInRenderer", true);

[Alexei Svitkine (slow), 2014/02/06 22:12:29]

I would actually suggest:

UMA_HISTOGRAM_BOOLEAN("Blacklist.PatchedInRenderer",
blacklist::IsBlacklistInitialized());

That way, the histogram will tell you the ratio of the two, rather than the
absolute count which is hard to analyze without a baseline to compare to.

Unless of course your question is only "is this happening at all", in which case
the current way is fine.

[csharp, 2014/02/06 22:21:59]

We just want the raw numbers since ideally this should always be false (we only
want to blacklist the browser process).

+#endif
+
     startup_timer.Stop();  // End of Startup Time Measurement.
 
     if (run_loop) {
 #if defined(OS_MACOSX)
       if (pool)
         pool->Recycle();
 #endif
       TRACE_EVENT_BEGIN_ETW("RendererMain.START_MSG_LOOP", 0, 0);
       base::MessageLoop::current()->Run();
       TRACE_EVENT_END_ETW("RendererMain.START_MSG_LOOP", 0, 0);
     }
   }
   platform.PlatformUninitialize();
   TRACE_EVENT_END_ETW("RendererMain", 0, "");
   return 0;
 }
 
 }  // namespace content