Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 140763006: Use ~/.gyp/include.gypi in GN build. (Closed)

Created:
6 years, 11 months ago by brettw
Modified:
6 years, 11 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Use ~/.gyp/include.gypi in GN build. This also fixes the goma toolchain definition. My conditions syntax was missing a set of []. R=scottmg@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245371

Patch Set 1 #

Patch Set 2 : Remove print #

Total comments: 3

Patch Set 3 : fix error if .gyp doesn't exist #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M build/gyp_chromium View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
M build/toolchain/linux/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
https://codereview.chromium.org/140763006/diff/30001/build/gyp_chromium File build/gyp_chromium (right): https://codereview.chromium.org/140763006/diff/30001/build/gyp_chromium#newcode133 build/gyp_chromium:133: home_dot_gyp = os.environ.get('GYP_CONFIG_DIR', None) This block is just copied ...
6 years, 11 months ago (2014-01-16 21:51:34 UTC) #1
scottmg
lgtm https://codereview.chromium.org/140763006/diff/30001/build/gyp_chromium File build/gyp_chromium (right): https://codereview.chromium.org/140763006/diff/30001/build/gyp_chromium#newcode139 build/gyp_chromium:139: home_vars.append('USERPROFILE') this seems a bit dumb, since this ...
6 years, 11 months ago (2014-01-16 22:00:30 UTC) #2
scottmg
On 2014/01/16 22:00:30, scottmg wrote: > lgtm trybots disagree, however.
6 years, 11 months ago (2014-01-16 22:00:52 UTC) #3
brettw
6 years, 11 months ago (2014-01-16 23:17:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r245371 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698