Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: cloud_print/BUILD.gn

Issue 1407623003: Revert of Add cloud_print to the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/version_resource_rules.gypi ('k') | cloud_print/cloud_print.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cloud_print/BUILD.gn
diff --git a/cloud_print/BUILD.gn b/cloud_print/BUILD.gn
index d92c3b28ab3d0ccc1736df93f4db7dfba6c73605..2cd785bc6f7857bf67cdfcdbee29d0f0851fe471 100644
--- a/cloud_print/BUILD.gn
+++ b/cloud_print/BUILD.gn
@@ -3,25 +3,6 @@
# found in the LICENSE file.
import("//testing/test.gni")
-
-group("cloud_print") {
- if (is_win) {
- public_deps = [
- "//cloud_print/service/win:cloud_print_service",
- "//cloud_print/service/win:cloud_print_service_config",
- "//cloud_print/service/win:cloud_print_service_setup",
- "//cloud_print/virtual_driver/win/install:virtual_driver_setup",
- "//cloud_print/virtual_driver/win/port_monitor",
- ]
-
- # When compiling 32-bit, also reference the 64-bit driver for installing on
- # 64-bit systems.
- if (target_cpu == "x86" && current_cpu == "x86") {
- # TODO(brettw) enable this when Windows cross-compiles are set up.
- # public_deps += [ "//cloud_print/virtual_driver/win/port_monitor(//build/toolchain/win:x64)" ]
- }
- }
-}
test("cloud_print_unittests") {
sources = [
@@ -31,17 +12,18 @@
deps = [
"//base",
"//base/test:run_all_unittests",
- "//cloud_print/service:lib",
+ "//cloud_print/service:cloud_print_service_lib",
"//testing/gmock",
"//testing/gtest",
]
- if (is_win) {
- sources += [
- "service/win/service_ipc_unittest.cc",
- "virtual_driver/win/port_monitor/port_monitor_unittest.cc",
- ]
- deps += [ "//cloud_print/virtual_driver/win/port_monitor:lib" ]
- libs = [ "secur32.lib" ]
- }
+ # TODO(GYP)
+ # if (is_win) {
+ # sources += [
+ # "service/win/service_ipc_unittest.cc",
+ # "virtual_driver/win/port_monitor/port_monitor_unittest.cc",
+ # ]
+ #
+ # deps += [ "virtual_driver/win:gcp_portmon_lib" ]
+ #}
}
« no previous file with comments | « chrome/version_resource_rules.gypi ('k') | cloud_print/cloud_print.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698