cloud_print/service/win/service.gyp - Issue 1407623003: Revert of Add cloud_print to the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/service/win/service.gyp

Issue 1407623003: Revert of Add cloud_print to the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cloud_print/service/win/service.gyp

diff --git a/cloud_print/service/win/service.gyp b/cloud_print/service/win/service.gyp

index 5434c497159b4644f7e26ed3d0a62f72c0cbed90..0019b6f1ca913ae6f19322a100aa4f311c1fe8ad 100644

--- a/cloud_print/service/win/service.gyp

+++ b/cloud_print/service/win/service.gyp

@@ -22,10 +22,11 @@

'_ATL_NO_AUTOMATIC_NAMESPACE',

'_ATL_NO_EXCEPTIONS',

+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.

+ 'msvs_disabled_warnings': [ 4267, ],

'targets': [

{

- # GN version: //cloud_print/service/win:cloud_print_service

'target_name': 'cloud_print_service',

'type': 'executable',

'sources': [

@@ -50,7 +51,6 @@

{

- # GN version: //cloud_print/service/win:cloud_print_service_config

'target_name': 'cloud_print_service_config',

'type': 'executable',

'sources': [

@@ -99,7 +99,6 @@

{

- # GN version: //cloud_print/service/win:cloud_print_service_setup

'target_name': 'cloud_print_service_setup',

'type': 'executable',

'sources': [

« no previous file with comments | « cloud_print/service/win/installer.cc ('k') | cloud_print/service/win/service_controller.h » ('j') | no next file with comments »