Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Issue 1407613004: [Android] Clear application state on instrumentation test failure. (Closed)

Created:
5 years, 2 months ago by jbudorick
Modified:
5 years, 2 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Clear application state on instrumentation test failure. Some (still-unidentified) instrumentation tests leave an account on the device, causing subsequent uses of the device to fail the DCHECK here: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/signin/oauth2_token_service_delegate_android.cc&l=552 Clearing the application state on failure should return the device to a viable state. This CL _does not_ resolve the underlying flake, but it does further mitigate its impact while I keep looking for it. BUG=533188 TBR=mikecase@chromium.org Committed: https://crrev.com/150d81724c609b042dffacf1e770945b81673ac7 Cr-Commit-Position: refs/heads/master@{#353964}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M build/android/pylib/instrumentation/test_runner.py View 1 chunk +14 lines, -13 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jbudorick
TBR: limited-scope change to address flakiness P0
5 years, 2 months ago (2015-10-14 03:33:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407613004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407613004/1
5 years, 2 months ago (2015-10-14 03:34:04 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 05:56:13 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/150d81724c609b042dffacf1e770945b81673ac7 Cr-Commit-Position: refs/heads/master@{#353964}
5 years, 2 months ago (2015-10-14 05:56:58 UTC) #5
mikecase (-- gone --)
lgtm, but why don't we always clear application state (on pass or failure)? And is ...
5 years, 2 months ago (2015-10-14 15:44:01 UTC) #6
jbudorick
5 years, 2 months ago (2015-10-14 15:46:17 UTC) #7
Message was sent while issue was closed.
On 2015/10/14 15:44:01, mikecase wrote:
> lgtm, but why don't we always clear application state (on pass or failure)?
And
> is there any reason we didn't do this before (is it slow?).

Yes, it is, and it's usually unnecessary.

Powered by Google App Engine
This is Rietveld 408576698