Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: runtime/vm/constants_mips.h

Issue 14076005: Supports FrameLookup vm test on MIPS (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/constants_mips.h
===================================================================
--- runtime/vm/constants_mips.h (revision 21219)
+++ runtime/vm/constants_mips.h (working copy)
@@ -144,6 +144,10 @@
const Register SPREG = SP; // Stack pointer register.
const Register FPREG = FP; // Frame pointer register.
+// The code that generates a comparison can be far away from the code that
+// generates the branch that uses the result of that comparison. In this case,
+// CMPRES is used for the result of the comparison.
+const Register CMPRES = T8;
typedef uint32_t RegList;
const RegList kAllCpuRegistersList = 0xFFFFFFFF;
@@ -162,10 +166,12 @@
static const int kFirstLocalSlotIndex = -2;
-// Values for the condition field. // UNIMPLEMENTED.
+// Values for the condition field.
+// There is no condition field on MIPS, but Conditions are used and passed
+// around by the intermediate language, so we need them here, too.
enum Condition {
- kNoCondition = -1,
- kMaxCondition = 16,
+ EQ, // equal
+ NE, // not equal
regis 2013/04/10 20:53:00 I am not sure this will work once you get other co
};

Powered by Google App Engine
This is Rietveld 408576698