Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1407583004: Changes to master to more closely match XFA. (Closed)

Created:
5 years, 2 months ago by Tom Sepez
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Changes to master to more closely match XFA. These files should change in master in order to reduce the number of "noise diffs" between master and XFA as seen in https://codereview.chromium.org/1399273003/ This includes: whitespace, matching header ordering, and implementing a GetPageFromFPDFPage() from XFA. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/c8ff50435b01b765e575c93038aee08eafc7d82c

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -42 lines) Patch
M fpdfsdk/src/formfiller/FFL_IFormFiller.cpp View 2 chunks +8 lines, -19 lines 1 comment Download
M fpdfsdk/src/fpdf_transformpage.cpp View 7 chunks +19 lines, -14 lines 1 comment Download
M fpdfsdk/src/fpdfdoc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfeditimg.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfeditpage.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M fpdfsdk/src/fpdfformfill.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, for review. The individual changes should make sense on their own merits as well ...
5 years, 2 months ago (2015-10-13 21:53:45 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1407583004/diff/1/fpdfsdk/src/formfiller/FFL_IFormFiller.cpp File fpdfsdk/src/formfiller/FFL_IFormFiller.cpp (left): https://codereview.chromium.org/1407583004/diff/1/fpdfsdk/src/formfiller/FFL_IFormFiller.cpp#oldcode528 fpdfsdk/src/formfiller/FFL_IFormFiller.cpp:528: return TRUE; uhhh
5 years, 2 months ago (2015-10-13 22:04:38 UTC) #3
Tom Sepez
5 years, 2 months ago (2015-10-13 22:17:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c8ff50435b01b765e575c93038aee08eafc7d82c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698