Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1407583002: A couple small fixes to service.md. (Closed)

Created:
5 years, 2 months ago by nweiz
Modified:
5 years, 2 months ago
Reviewers:
turnidge, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

A couple small fixes to service.md. This adds VMUpdate to the EventKind enum and fixes a formatting issue with the table of contents. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/be692b5c9f35e3833cb7688c5c70425e2d8c3b75

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M runtime/vm/service/service.md View 2 chunks +5 lines, -1 line 3 comments Download

Messages

Total messages: 7 (2 generated)
nweiz
5 years, 2 months ago (2015-10-13 19:56:19 UTC) #2
Cutch
LGTM after sorting the enum https://codereview.chromium.org/1407583002/diff/1/runtime/vm/service/service.md File runtime/vm/service/service.md (right): https://codereview.chromium.org/1407583002/diff/1/runtime/vm/service/service.md#newcode1143 runtime/vm/service/service.md:1143: VMUpdate, Sort.
5 years, 2 months ago (2015-10-13 19:58:09 UTC) #4
nweiz
https://codereview.chromium.org/1407583002/diff/1/runtime/vm/service/service.md File runtime/vm/service/service.md (right): https://codereview.chromium.org/1407583002/diff/1/runtime/vm/service/service.md#newcode1143 runtime/vm/service/service.md:1143: VMUpdate, On 2015/10/13 19:58:09, Cutch wrote: > Sort. Sort ...
5 years, 2 months ago (2015-10-13 20:12:49 UTC) #5
Cutch
lgtm https://codereview.chromium.org/1407583002/diff/1/runtime/vm/service/service.md File runtime/vm/service/service.md (right): https://codereview.chromium.org/1407583002/diff/1/runtime/vm/service/service.md#newcode1143 runtime/vm/service/service.md:1143: VMUpdate, On 2015/10/13 20:12:49, nweiz wrote: > On ...
5 years, 2 months ago (2015-10-13 20:13:56 UTC) #6
nweiz
5 years, 2 months ago (2015-10-13 20:16:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
be692b5c9f35e3833cb7688c5c70425e2d8c3b75 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698