Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1407573002: Fix race in thread iterator test (Closed)

Created:
5 years, 2 months ago by Cutch
Modified:
5 years, 2 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix race in thread iterator test - Explicitly join the spawned thread to ensure the destructors have run. - This will fail on Windows bots (I'd like to see this before updating the status file). Committed: https://github.com/dart-lang/sdk/commit/d565c5361e9b264fabebaeea6987e613a4b5e1a8

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -51 lines) Patch
M runtime/vm/thread_test.cc View 1 chunk +57 lines, -51 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
Cutch
TBR
5 years, 2 months ago (2015-10-13 19:56:36 UTC) #2
Cutch
Committed patchset #1 (id:1) manually as d565c5361e9b264fabebaeea6987e613a4b5e1a8 (presubmit successful).
5 years, 2 months ago (2015-10-13 19:56:46 UTC) #3
siva
5 years, 2 months ago (2015-10-13 21:38:58 UTC) #4
Message was sent while issue was closed. 
lgtm

https://codereview.chromium.org/1407573002/diff/1/runtime/vm/thread_test.cc
File runtime/vm/thread_test.cc (right):

https://codereview.chromium.org/1407573002/diff/1/runtime/vm/thread_test.cc#n...
runtime/vm/thread_test.cc:479: params->spawned_thread_join_id =
OSThread::GetCurrentThreadJoinId();
ASSERT(params->spawned_thread_join_id != OSThread::kInvalidThreadJoinId);

as the wait condition depends on this.

Powered by Google App Engine
This is Rietveld 408576698