third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 1407543003: Preliminary paint property walk implementation for SPv2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1407543003: Preliminary paint property walk implementation for SPv2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: minor bug fix (perspective does not clear paint offset). switch test to unit test style. add a few … Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.h ('k') | third_party/WebKit/Source/core/layout/LayoutObject.h » ('j') | third_party/WebKit/Source/core/layout/LayoutObject.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index e4351ba572749035cc38919dd064fa8460d74e48..0c4fc3c52a01dec4f0439be535c413a97eb583c2 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -76,6 +76,7 @@

#include "core/page/scrolling/ScrollingCoordinator.h"

#include "core/paint/FramePainter.h"

#include "core/paint/PaintLayer.h"

+#include "core/paint/PaintPropertyTreeBuilder.h"

#include "core/style/ComputedStyle.h"

#include "core/svg/SVGDocumentExtensions.h"

#include "core/svg/SVGSVGElement.h"

@@ -2472,9 +2473,9 @@ void FrameView::updatePaintProperties()

{

ASSERT(RuntimeEnabledFeatures::slimmingPaintV2Enabled());

- forAllFrameViews([](FrameView& frameView) { frameView.lifecycle().advanceTo(DocumentLifecycle::InUpdatePaintProperties); });

- // TODO(pdr): Calculate the paint properties by walking the layout tree.

- forAllFrameViews([](FrameView& frameView) { frameView.lifecycle().advanceTo(DocumentLifecycle::UpdatePaintPropertiesClean); });

+ lifecycle().advanceTo(DocumentLifecycle::InUpdatePaintProperties);

+ PaintPropertyTreeBuilder().buildPropertyTrees(*this);

+ lifecycle().advanceTo(DocumentLifecycle::UpdatePaintPropertiesClean);

}

void FrameView::synchronizedPaint(const LayoutRect* interestRect)