third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp - Issue 1407543003: Preliminary paint property walk implementation for SPv2

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp

Issue 1407543003: Preliminary paint property walk implementation for SPv2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revert forAllFrameViews change in FrameView.cpp. I don't know what I was thinking. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvasTest.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp b/third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp

index cef323584a02247f4137694fb1c0321e79daeffb..d1084c54309e085326b819a45bbe2f73ed471a77 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp

@@ -86,13 +86,13 @@ TEST_F(PaintChunkerTest, BuildMultipleChunksWithSinglePropertyChanging)

chunker.incrementDisplayItemIndex();

PaintChunkProperties simpleTransform;

- simpleTransform.transform = adoptRef(new TransformPaintPropertyNode(TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7)));

+ simpleTransform.transform = TransformPaintPropertyNode::create(TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7));

chunker.updateCurrentPaintChunkProperties(simpleTransform);

chunker.incrementDisplayItemIndex();

PaintChunkProperties anotherTransform;

- anotherTransform.transform = adoptRef(new TransformPaintPropertyNode(TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7)));

+ anotherTransform.transform = TransformPaintPropertyNode::create(TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7));

chunker.updateCurrentPaintChunkProperties(anotherTransform);

chunker.incrementDisplayItemIndex();

@@ -114,7 +114,7 @@ TEST_F(PaintChunkerTest, BuildLinearChunksFromNestedTransforms)

chunker.incrementDisplayItemIndex();

PaintChunkProperties simpleTransform;

- simpleTransform.transform = adoptRef(new TransformPaintPropertyNode(TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7)));

+ simpleTransform.transform = TransformPaintPropertyNode::create(TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7));

chunker.updateCurrentPaintChunkProperties(simpleTransform);

chunker.incrementDisplayItemIndex();

@@ -138,11 +138,11 @@ TEST_F(PaintChunkerTest, ChangingPropertiesWithoutItems)

chunker.incrementDisplayItemIndex();

PaintChunkProperties firstTransform;

- firstTransform.transform = adoptRef(new TransformPaintPropertyNode(TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7)));

+ firstTransform.transform = TransformPaintPropertyNode::create(TransformationMatrix(0, 1, 2, 3, 4, 5), FloatPoint3D(9, 8, 7));

chunker.updateCurrentPaintChunkProperties(firstTransform);

PaintChunkProperties secondTransform;

- secondTransform.transform = adoptRef(new TransformPaintPropertyNode(TransformationMatrix(9, 8, 7, 6, 5, 4), FloatPoint3D(3, 2, 1)));

+ secondTransform.transform = TransformPaintPropertyNode::create(TransformationMatrix(9, 8, 7, 6, 5, 4), FloatPoint3D(3, 2, 1));

chunker.updateCurrentPaintChunkProperties(secondTransform);

chunker.incrementDisplayItemIndex();