third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvasTest.cpp - Issue 1407543003: Preliminary paint property walk implementation for SPv2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvasTest.cpp

Issue 1407543003: Preliminary paint property walk implementation for SPv2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address the feedback Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/paint/test_data/fixed-position.html ('K') | « third_party/WebKit/Source/core/paint/test_data/transform.html ('k') | third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvasTest.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvasTest.cpp b/third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvasTest.cpp

index b8960dc7e3d2e285291e245c48e4f4f3fe100c25..f35636509adf8b46e20960d8e3f96daccab1fb70 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvasTest.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintArtifactToSkCanvasTest.cpp

@@ -125,10 +125,10 @@ TEST(PaintArtifactToSkCanvasTest, TransformCombining)

TransformationMatrix matrix1;

matrix1.scale(2);

FloatPoint3D origin1(10, 10, 0);

- RefPtr<TransformPaintPropertyNode> transform1 = adoptRef(new TransformPaintPropertyNode(matrix1, origin1));

+ RefPtr<TransformPaintPropertyNode> transform1 = TransformPaintPropertyNode::create(matrix1, origin1);

TransformationMatrix matrix2;

matrix2.translate(5, 5);

- RefPtr<TransformPaintPropertyNode> transform2 = adoptRef(new TransformPaintPropertyNode(matrix2, FloatPoint3D(), transform1.get()));

+ RefPtr<TransformPaintPropertyNode> transform2 = TransformPaintPropertyNode::create(matrix2, FloatPoint3D(), transform1.get());

// Build a two-chunk artifact directly.

PaintArtifact artifact;