Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1407543003: Preliminary paint property walk implementation for SPv2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address the feedback Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index 8628654867586e554f1c3f330134d095856b5790..1bc46d4a06e421790985a171a7132b6f5e440ee3 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -76,6 +76,7 @@
#include "core/page/scrolling/ScrollingCoordinator.h"
#include "core/paint/FramePainter.h"
#include "core/paint/PaintLayer.h"
+#include "core/paint/PaintPropertyTreeBuilder.h"
#include "core/style/ComputedStyle.h"
#include "core/svg/SVGDocumentExtensions.h"
#include "core/svg/SVGSVGElement.h"
@@ -2478,9 +2479,9 @@ void FrameView::updatePaintProperties()
{
ASSERT(RuntimeEnabledFeatures::slimmingPaintV2Enabled());
- forAllFrameViews([](FrameView& frameView) { frameView.lifecycle().advanceTo(DocumentLifecycle::InUpdatePaintProperties); });
- // TODO(pdr): Calculate the paint properties by walking the layout tree.
- forAllFrameViews([](FrameView& frameView) { frameView.lifecycle().advanceTo(DocumentLifecycle::UpdatePaintPropertiesClean); });
+ lifecycle().advanceTo(DocumentLifecycle::InUpdatePaintProperties);
+ PaintPropertyTreeBuilder().buildPropertyTrees(*this);
+ lifecycle().advanceTo(DocumentLifecycle::UpdatePaintPropertiesClean);
}
void FrameView::synchronizedPaint(const LayoutRect* interestRect)

Powered by Google App Engine
This is Rietveld 408576698