third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp - Issue 1407543003: Preliminary paint property walk implementation for SPv2

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp

Issue 1407543003: Preliminary paint property walk implementation for SPv2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add test fixture Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTestHelper.h ('k') | third_party/WebKit/Source/core/paint/ObjectPaintProperties.h » ('j') | third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "config.h"	5 #include "config.h"

6 #include "core/layout/LayoutTestHelper.h"	6 #include "core/layout/LayoutTestHelper.h"

7	7

8 #include "core/loader/EmptyClients.h"	8 #include "core/loader/EmptyClients.h"

9 #include "platform/graphics/GraphicsLayer.h"	9 #include "platform/graphics/GraphicsLayer.h"

10 #include "platform/graphics/GraphicsLayerFactory.h"	10 #include "platform/graphics/GraphicsLayerFactory.h"

(...skipping 39 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
50 fillWithEmptyClients(pageClients);	50 fillWithEmptyClients(pageClients);

51 DEFINE_STATIC_LOCAL(OwnPtrWillBePersistent<FakeChromeClient>, chromeClient, (FakeChromeClient::create()));	51 DEFINE_STATIC_LOCAL(OwnPtrWillBePersistent<FakeChromeClient>, chromeClient, (FakeChromeClient::create()));

52 pageClients.chromeClient = chromeClient.get();	52 pageClients.chromeClient = chromeClient.get();

53 m_pageHolder = DummyPageHolder::create(IntSize(800, 600), &pageClients, null ptr, settingOverrider());	53 m_pageHolder = DummyPageHolder::create(IntSize(800, 600), &pageClients, null ptr, settingOverrider());

54	54

55 // This ensures that the minimal DOM tree gets attached	55 // This ensures that the minimal DOM tree gets attached

56 // correctly for tests that don't call setBodyInnerHTML.	56 // correctly for tests that don't call setBodyInnerHTML.

57 document().view()->updateAllLifecyclePhases();	57 document().view()->updateAllLifecyclePhases();

58 }	58 }

59	59

	60 void RenderingTest::TearDown()

	61 {

	62 m_pageHolder = nullptr;
	jbroman 2015/10/16 14:46:51 Why is this necessary? Doesn't this already happen Why is this necessary? Doesn't this already happen during ~RenderingTest? trchen 2015/10/20 05:11:47 Ordering issue. We toggle RuntimeEnabledFeatures b Show quoted text On 2015/10/16 14:46:51, jbroman wrote: > Why is this necessary? Doesn't this already happen during ~RenderingTest? Ordering issue. We toggle RuntimeEnabledFeatures back during ::TearDown, which happens before the destructor. Then LayoutObject destructor freaks out because it sees itself owning paint properties without SPv2 enabled.
	63 }

60	64

61 } // namespace blink	65 } // namespace blink

OLD	NEW