Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1407543003: Preliminary paint property walk implementation for SPv2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert forAllFrameViews change in FrameView.cpp. I don't know what I was thinking. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 #include "core/loader/FrameLoader.h" 69 #include "core/loader/FrameLoader.h"
70 #include "core/loader/FrameLoaderClient.h" 70 #include "core/loader/FrameLoaderClient.h"
71 #include "core/page/AutoscrollController.h" 71 #include "core/page/AutoscrollController.h"
72 #include "core/page/ChromeClient.h" 72 #include "core/page/ChromeClient.h"
73 #include "core/page/FocusController.h" 73 #include "core/page/FocusController.h"
74 #include "core/page/FrameTree.h" 74 #include "core/page/FrameTree.h"
75 #include "core/page/Page.h" 75 #include "core/page/Page.h"
76 #include "core/page/scrolling/ScrollingCoordinator.h" 76 #include "core/page/scrolling/ScrollingCoordinator.h"
77 #include "core/paint/FramePainter.h" 77 #include "core/paint/FramePainter.h"
78 #include "core/paint/PaintLayer.h" 78 #include "core/paint/PaintLayer.h"
79 #include "core/paint/PaintPropertyTreeBuilder.h"
79 #include "core/style/ComputedStyle.h" 80 #include "core/style/ComputedStyle.h"
80 #include "core/svg/SVGDocumentExtensions.h" 81 #include "core/svg/SVGDocumentExtensions.h"
81 #include "core/svg/SVGSVGElement.h" 82 #include "core/svg/SVGSVGElement.h"
82 #include "platform/HostWindow.h" 83 #include "platform/HostWindow.h"
83 #include "platform/RuntimeEnabledFeatures.h" 84 #include "platform/RuntimeEnabledFeatures.h"
84 #include "platform/ScriptForbiddenScope.h" 85 #include "platform/ScriptForbiddenScope.h"
85 #include "platform/TraceEvent.h" 86 #include "platform/TraceEvent.h"
86 #include "platform/TracedValue.h" 87 #include "platform/TracedValue.h"
87 #include "platform/fonts/FontCache.h" 88 #include "platform/fonts/FontCache.h"
88 #include "platform/geometry/DoubleRect.h" 89 #include "platform/geometry/DoubleRect.h"
(...skipping 2383 matching lines...) Expand 10 before | Expand all | Expand 10 after
2472 } 2473 }
2473 2474
2474 updateViewportIntersectionsForSubtree(); 2475 updateViewportIntersectionsForSubtree();
2475 } 2476 }
2476 2477
2477 void FrameView::updatePaintProperties() 2478 void FrameView::updatePaintProperties()
2478 { 2479 {
2479 ASSERT(RuntimeEnabledFeatures::slimmingPaintV2Enabled()); 2480 ASSERT(RuntimeEnabledFeatures::slimmingPaintV2Enabled());
2480 2481
2481 forAllFrameViews([](FrameView& frameView) { frameView.lifecycle().advanceTo( DocumentLifecycle::InUpdatePaintProperties); }); 2482 forAllFrameViews([](FrameView& frameView) { frameView.lifecycle().advanceTo( DocumentLifecycle::InUpdatePaintProperties); });
2482 // TODO(pdr): Calculate the paint properties by walking the layout tree. 2483 PaintPropertyTreeBuilder().buildPropertyTrees(*this);
2483 forAllFrameViews([](FrameView& frameView) { frameView.lifecycle().advanceTo( DocumentLifecycle::UpdatePaintPropertiesClean); }); 2484 forAllFrameViews([](FrameView& frameView) { frameView.lifecycle().advanceTo( DocumentLifecycle::UpdatePaintPropertiesClean); });
2484 } 2485 }
2485 2486
2486 void FrameView::synchronizedPaint(const LayoutRect* interestRect) 2487 void FrameView::synchronizedPaint(const LayoutRect* interestRect)
2487 { 2488 {
2488 ASSERT(RuntimeEnabledFeatures::slimmingPaintSynchronizedPaintingEnabled()); 2489 ASSERT(RuntimeEnabledFeatures::slimmingPaintSynchronizedPaintingEnabled());
2489 ASSERT(frame() == page()->mainFrame() || (!frame().tree().parent()->isLocalF rame())); 2490 ASSERT(frame() == page()->mainFrame() || (!frame().tree().parent()->isLocalF rame()));
2490 2491
2491 LayoutView* view = layoutView(); 2492 LayoutView* view = layoutView();
2492 ASSERT(view); 2493 ASSERT(view);
(...skipping 1584 matching lines...) Expand 10 before | Expand all | Expand 10 after
4077 } 4078 }
4078 4079
4079 bool FrameView::canThrottleRendering() const 4080 bool FrameView::canThrottleRendering() const
4080 { 4081 {
4081 if (!RuntimeEnabledFeatures::renderingPipelineThrottlingEnabled()) 4082 if (!RuntimeEnabledFeatures::renderingPipelineThrottlingEnabled())
4082 return false; 4083 return false;
4083 return m_hiddenForThrottling && m_crossOriginForThrottling; 4084 return m_hiddenForThrottling && m_crossOriginForThrottling;
4084 } 4085 }
4085 4086
4086 } // namespace blink 4087 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.h ('k') | third_party/WebKit/Source/core/layout/LayoutObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698