Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: test/cctest/test-sampler-api.cc

Issue 1407533004: [turbofan] Fix various issues with --turbo-inlining enabled. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comment. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-profile-generator.cc ('k') | test/mjsunit/mjsunit.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-sampler-api.cc
diff --git a/test/cctest/test-sampler-api.cc b/test/cctest/test-sampler-api.cc
index 99a89fbec45dbeabca5a5dd0f3d61223d0afeb1c..3506c4b38bf330463c3d7609efb8cc3a1ed0a887 100644
--- a/test/cctest/test-sampler-api.cc
+++ b/test/cctest/test-sampler-api.cc
@@ -226,16 +226,17 @@ TEST(StackDepthDoesNotExceedMaxValue) {
// ^ ^ ^
// sample.stack indices 2 1 0
TEST(StackFramesConsistent) {
- // Note: The arguments.callee stuff is there so that the
- // functions are not optimized away.
+ i::FLAG_allow_natives_syntax = true;
const char* test_script =
"function test_sampler_api_inner() {"
" CollectSample();"
- " return arguments.callee.toString();"
+ " return 0;"
"}"
"function test_sampler_api_outer() {"
- " return test_sampler_api_inner() + arguments.callee.toString();"
+ " return test_sampler_api_inner();"
"}"
+ "%NeverOptimizeFunction(test_sampler_api_inner);"
+ "%NeverOptimizeFunction(test_sampler_api_outer);"
"test_sampler_api_outer();";
SamplingTestHelper helper(test_script);
« no previous file with comments | « test/cctest/test-profile-generator.cc ('k') | test/mjsunit/mjsunit.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698