Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: test/cctest/test-debug.cc

Issue 1407533004: [turbofan] Fix various issues with --turbo-inlining enabled. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comment. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/cctest/test-deoptimization.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-debug.cc
diff --git a/test/cctest/test-debug.cc b/test/cctest/test-debug.cc
index e2ba3f5d1c469f60b97e06a5df08a8b879b6055d..0fce405297556c9900ad1088718c38c230cdbbf3 100644
--- a/test/cctest/test-debug.cc
+++ b/test/cctest/test-debug.cc
@@ -6065,6 +6065,7 @@ static void DebugBreakMessageHandler(const v8::Debug::Message& message) {
// Test that a debug break can be scheduled while in a message handler.
TEST(DebugBreakInMessageHandler) {
+ i::FLAG_turbo_inlining = false; // Make sure g is not inlined into f.
DebugLocalContext env;
v8::HandleScope scope(env->GetIsolate());
@@ -6078,7 +6079,7 @@ TEST(DebugBreakInMessageHandler) {
v8::Local<v8::Function> g = v8::Local<v8::Function>::Cast(
env->Global()->Get(v8::String::NewFromUtf8(env->GetIsolate(), "g")));
- // Call f then g. The debugger statement in f will casue a break which will
+ // Call f then g. The debugger statement in f will cause a break which will
// cause another break.
f->Call(env->Global(), 0, NULL);
CHECK_EQ(2, message_handler_break_hit_count);
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/cctest/test-deoptimization.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698