src/compiler/js-type-feedback-lowering.cc - Issue 1407533004: [turbofan] Fix various issues with --turbo-inlining enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-type-feedback-lowering.cc

Issue 1407533004: [turbofan] Fix various issues with --turbo-inlining enabled. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comment. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/js-type-feedback-lowering.cc

diff --git a/src/compiler/js-type-feedback-lowering.cc b/src/compiler/js-type-feedback-lowering.cc

index d97a305d08cdcb822fb6305a4d6ee0f1c2cabf7e..b618bf65e022d53407d9678e8168e706bf1bba11 100644

--- a/src/compiler/js-type-feedback-lowering.cc

+++ b/src/compiler/js-type-feedback-lowering.cc

@@ -43,7 +43,7 @@ Reduction JSTypeFeedbackLowering::ReduceJSLoadNamed(Node* node) {

// We need to make optimistic assumptions to continue.

if (!(flags() & kDeoptimizationEnabled)) return NoChange();

LoadNamedParameters const& p = LoadNamedParametersOf(node->op());

- if (p.feedback().vector().is_null()) return NoChange();

+ if (!p.feedback().IsValid()) return NoChange(); // No feedback.

if (p.name().is_identical_to(factory()->length_string())) {

LoadICNexus nexus(p.feedback().vector(), p.feedback().slot());

MapHandleList maps;

« no previous file with comments | « src/compiler/js-operator.h ('k') | src/compiler/node-properties.h » ('j') | no next file with comments »