[turbofan] Fix various issues with --turbo-inlining enabled.

src/compiler/js-inlining-heuristic.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/js-inlining-heuristic.h"
 
 #include "src/compiler/dead-code-elimination.h"  // TODO(mstarzinger): Remove!
 #include "src/compiler/node-matchers.h"
 #include "src/objects-inl.h"
 
@@ skipping 38 matching lines @@
     return NoChange();
   }
 
   // Quick check on the size of the AST to avoid parsing large candidate.
   if (function->shared()->ast_node_count() > FLAG_max_inlined_nodes) {
     return NoChange();
   }
 
   // Gather feedback on how often this call site has been hit before.
   CallFunctionParameters p = CallFunctionParametersOf(node->op());
+  if (!p.feedback().IsValid()) return NoChange();  // No feedback.

[Benedikt Meurer, 2015/10/15 11:18:23]

Nit: Can we set call count to zero in this case? I'd prefer to also be able to
inline call sites that were never executed so far based on other criteria.

[Michael Starzinger, 2015/10/15 11:29:30]

Done. As discussed offline, I used {-1} instead of {0} to be in sync with the
default value that CallICNexus::ExtractCallCount returns. Left a comment in that
regard as well.

   CallICNexus nexus(p.feedback().vector(), p.feedback().slot());
   int calls = nexus.ExtractCallCount();
 
   // ---------------------------------------------------------------------------
   // Everything above this line is part of the inlining heuristic.
   // ---------------------------------------------------------------------------
 
   // In the general case we remember the candidate for later.
   candidates_.push_back({function, node, calls});
   return NoChange();
@@ skipping 36 matching lines @@
            candidate.node->id(), candidate.calls,
            candidate.function->shared()->SourceSize(),
            candidate.function->shared()->ast_node_count(),
            candidate.function->shared()->DebugName()->ToCString().get());
   }
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8