Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 140753009: Fix MOAR warnings for dart:html. (Closed)

Created:
6 years, 10 months ago by Emily Fortuna
Modified:
6 years, 10 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix MOAR warnings for dart:html. BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=32403

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -6 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 4 chunks +47 lines, -1 line 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 5 chunks +48 lines, -2 lines 0 comments Download
M sdk/lib/html/html_common/lists.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/CrossFrameTypes.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/WrappedEvent.dart View 2 chunks +37 lines, -0 lines 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
part 2 of a bazillion
6 years, 10 months ago (2014-02-07 01:46:03 UTC) #1
blois
lgtm
6 years, 10 months ago (2014-02-07 02:08:26 UTC) #2
Emily Fortuna
6 years, 10 months ago (2014-02-07 02:20:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r32403 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698