Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2812)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwSettings.java

Issue 140753006: [Android WebView] Turn on accelerated canvas based on View.isHardwareAccelerated (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/AwSettings.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwSettings.java b/android_webview/java/src/org/chromium/android_webview/AwSettings.java
index 6cc8e532ef99d5912feb9acabd0788e3eb1ebefc..90c915245df740bcd77848fdcc4b649e491304d1 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwSettings.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwSettings.java
@@ -82,6 +82,8 @@ public class AwSettings {
private String mDefaultVideoPosterURL;
private float mInitialPageScalePercent = 0;
private boolean mSpatialNavigationEnabled; // Default depends on device features.
+ // May map to multiple webkit preferences.
mnaganov (inactive) 2014/01/17 09:56:22 nit: We already have settings that map to multiple
boliu 2014/01/17 14:58:49 Ok, removed comment.
+ private boolean enableSupportedHardwareAcceleratedFeatures = false;
mnaganov (inactive) 2014/01/17 09:56:22 mEnableSupportedHardwareAcceleratedFeatures
boliu 2014/01/17 14:58:49 Done.
private final boolean mSupportLegacyQuirks;
@@ -181,7 +183,9 @@ public class AwSettings {
while (mIsUpdateWebkitPrefsMessagePending) {
mAwSettingsLock.wait();
}
- } catch (InterruptedException e) {}
+ } catch (InterruptedException e) {
+ // Nothing to do.
boliu 2014/01/16 23:59:37 This is to handle a presubmit warning.
mnaganov (inactive) 2014/01/17 09:56:22 FYI, Ben is also fixing this in https://codereview
boliu 2014/01/17 14:58:49 Ok, no-op to avoid conflicts then.
+ }
}
}
}
@@ -390,6 +394,20 @@ public class AwSettings {
return mSpatialNavigationEnabled;
}
+ void setEnableSupportedHardwareAcceleratedFeatures(boolean enable) {
+ synchronized (mAwSettingsLock) {
+ if (enableSupportedHardwareAcceleratedFeatures != enable) {
+ enableSupportedHardwareAcceleratedFeatures = enable;
+ mEventHandler.updateWebkitPreferencesLocked();
+ }
+ }
+ }
+
+ @CalledByNative
+ private boolean getEnableSupportedHardwareAcceleratedFeatures() {
mnaganov (inactive) 2014/01/17 09:56:22 Please add "Locked" suffix, since those getters ar
boliu 2014/01/17 14:58:49 Done.
+ return enableSupportedHardwareAcceleratedFeatures;
+ }
+
/**
* See {@link android.webkit.WebSettings#setNeedInitialFocus}.
*/

Powered by Google App Engine
This is Rietveld 408576698