[Android WebView] Turn on accelerated canvas based on View.isHardwareAccelerated

[Android WebView] Turn on accelerated canvas based on View.isHardwareAccelerated

In onAttachedToWindow, check that if the view is hardware accelerated,
then enable hardware accelerated 2d canvas. Similarly disable canvas on
detach.

Note that accelerated 2d canvas is still off by default, but this patch
adds a command line switch to turn it on.

BUG=332273
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245648

[boliu, 2014-01-16 23:59:36]

PTAL

https://codereview.chromium.org/140753006/diff/1/android_webview/java/src/org...
File android_webview/java/src/org/chromium/android_webview/AwSettings.java
(right):

https://codereview.chromium.org/140753006/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwSettings.java:187: //
Nothing to do.
This is to handle a presubmit warning.

[mnaganov (inactive), 2014-01-17 09:56:22]

https://codereview.chromium.org/140753006/diff/1/android_webview/java/src/org...
File android_webview/java/src/org/chromium/android_webview/AwSettings.java
(right):

https://codereview.chromium.org/140753006/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwSettings.java:85: // May
map to multiple webkit preferences.
nit: We already have settings that map to multiple prefs, no need to declare
this.

https://codereview.chromium.org/140753006/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwSettings.java:86:
private boolean enableSupportedHardwareAcceleratedFeatures = false;
mEnableSupportedHardwareAcceleratedFeatures

https://codereview.chromium.org/140753006/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwSettings.java:187: //
Nothing to do.
On 2014/01/16 23:59:37, boliu wrote:
> This is to handle a presubmit warning.

FYI, Ben is also fixing this in https://codereview.chromium.org/140913003/

https://codereview.chromium.org/140753006/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwSettings.java:407:
private boolean getEnableSupportedHardwareAcceleratedFeatures() {
Please add "Locked" suffix, since those getters are called while holding
mAwSettingsLock.

https://codereview.chromium.org/140753006/diff/1/android_webview/native/aw_se...
File android_webview/native/aw_settings.cc (right):

https://codereview.chromium.org/140753006/diff/1/android_webview/native/aw_se...
android_webview/native/aw_settings.cc:319:
!CommandLine::ForCurrentProcess()->HasSwitch(
I don't really like checking the command line on each settings sync. Since this
can't change during the app lifetime, I guess, it would be better to find out
the value of the switch in the constructor.

[boliu, 2014-01-17 14:58:48]

Comments addressed. PTAL. Thanks!

https://codereview.chromium.org/140753006/diff/1/android_webview/java/src/org...
File android_webview/java/src/org/chromium/android_webview/AwSettings.java
(right):

https://codereview.chromium.org/140753006/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwSettings.java:85: // May
map to multiple webkit preferences.
On 2014/01/17 09:56:22, Mikhail Naganov (Cr) wrote:
> nit: We already have settings that map to multiple prefs, no need to declare
> this.

Ok, removed comment.

https://codereview.chromium.org/140753006/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwSettings.java:86:
private boolean enableSupportedHardwareAcceleratedFeatures = false;
On 2014/01/17 09:56:22, Mikhail Naganov (Cr) wrote:
> mEnableSupportedHardwareAcceleratedFeatures

Done.

https://codereview.chromium.org/140753006/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwSettings.java:187: //
Nothing to do.
On 2014/01/17 09:56:22, Mikhail Naganov (Cr) wrote:
> On 2014/01/16 23:59:37, boliu wrote:
> > This is to handle a presubmit warning.
> 
> FYI, Ben is also fixing this in https://codereview.chromium.org/140913003/

Ok, no-op to avoid conflicts then.

https://codereview.chromium.org/140753006/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwSettings.java:407:
private boolean getEnableSupportedHardwareAcceleratedFeatures() {
On 2014/01/17 09:56:22, Mikhail Naganov (Cr) wrote:
> Please add "Locked" suffix, since those getters are called while holding
> mAwSettingsLock.

Done.

https://codereview.chromium.org/140753006/diff/1/android_webview/native/aw_se...
File android_webview/native/aw_settings.cc (right):

https://codereview.chromium.org/140753006/diff/1/android_webview/native/aw_se...
android_webview/native/aw_settings.cc:319:
!CommandLine::ForCurrentProcess()->HasSwitch(
On 2014/01/17 09:56:22, Mikhail Naganov (Cr) wrote:
> I don't really like checking the command line on each settings sync. Since
this
> can't change during the app lifetime, I guess, it would be better to find out
> the value of the switch in the constructor.

I guess that's the right tradeoff. Added an instance var and moved the switch
check to constructor.

[mnaganov (inactive), 2014-01-17 15:58:58]

LGTM!

[commit-bot: I haz the power, 2014-01-17 16:21:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/140753006/90001

[commit-bot: I haz the power, 2014-01-17 19:29:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/140753006/90001

[commit-bot: I haz the power, 2014-01-17 20:47:01]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-17 20:50:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/140753006/90001

[commit-bot: I haz the power, 2014-01-17 22:50:07]

Change committed as 245648