Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 14075017: Disable ParserSync test in GC stress mode for now. (Closed)

Created:
7 years, 8 months ago by Michael Starzinger
Modified:
7 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Disable ParserSync test in GC stress mode for now. R=jkummerow@chromium.org TEST=cctest/test-parsing/ParserSync Committed: http://code.google.com/p/v8/source/detail?r=14376

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Jakob Kummerow. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M test/cctest/test-parsing.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
7 years, 8 months ago (2013-04-22 14:29:07 UTC) #1
Jakob Kummerow
lgtm https://codereview.chromium.org/14075017/diff/1/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/14075017/diff/1/test/cctest/test-parsing.cc#newcode1242 test/cctest/test-parsing.cc:1242: // correct timeout for this an re-enable this ...
7 years, 8 months ago (2013-04-22 14:32:05 UTC) #2
Michael Starzinger
Addressed comments. Landing. https://codereview.chromium.org/14075017/diff/1/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/14075017/diff/1/test/cctest/test-parsing.cc#newcode1242 test/cctest/test-parsing.cc:1242: // correct timeout for this an ...
7 years, 8 months ago (2013-04-22 14:37:22 UTC) #3
Michael Starzinger
7 years, 8 months ago (2013-04-22 14:38:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r14376 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698