Issue 14075014: Fixed issue in StoreNamedField codegen where integer32 constants were not converted to a smi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14075014: Fixed issue in StoreNamedField codegen where integer32 constants were not converted to a smi. (Closed)

Created:
7 years, 8 months ago by mvstanton

Modified:
7 years, 8 months ago

Reviewers:
Toon Verwaest, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fixed issue in StoreNamedField codegen where integer32 constants were not converted to a smi. BUG= Committed: https://code.google.com/p/v8/source/detail?r=14380

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -42 lines)			Patch
M	src/ia32/lithium-codegen-ia32.cc	View	1	1 chunk	+8 lines, -8 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1	3 chunks	+25 lines, -11 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1	1 chunk	+9 lines, -9 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1	3 chunks	+32 lines, -14 lines	0 comments	Download

Total messages: 5 (0 generated)

mvstanton

Here is the fix for StoreNamedField. I convert the integer constant to a smi before ...

7 years, 8 months ago (2013-04-22 11:17:00 UTC) #1

mvstanton

On 2013/04/22 15:01:24, danno wrote: > lgtm, but what about ARM? thx, ARM actually didn't ...

7 years, 8 months ago (2013-04-22 15:02:18 UTC) #3

mvstanton

7 years, 8 months ago (2013-04-22 15:35:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r14380 (presubmit successful).