Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 14075013: Replace CheckBuilder with IfBuilder everywhere. (Closed)

Created:
7 years, 8 months ago by Michael Starzinger
Modified:
7 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Replace CheckBuilder with IfBuilder everywhere. This deprecates and removes the CheckBuilder which is less powerful than the generic IfBuilder which can deopt as well by now. R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14372

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -95 lines) Patch
M src/code-stubs-hydrogen.cc View 8 chunks +18 lines, -10 lines 0 comments Download
M src/hydrogen.h View 3 chunks +16 lines, -21 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +1 line, -64 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 8 months ago (2013-04-22 11:07:08 UTC) #1
Jakob Kummerow
LGTM. Nifty.
7 years, 8 months ago (2013-04-22 11:12:03 UTC) #2
Michael Starzinger
7 years, 8 months ago (2013-04-22 11:15:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14372 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698