src/heap.cc - Issue 14075012: Expose the GC under a name that is less collision prone than window.gc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap.cc

Issue 14075012: Expose the GC under a name that is less collision prone than window.gc. (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: --expose-gc-as Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap.cc

diff --git a/src/heap.cc b/src/heap.cc

index 10cb4738abdf66c07be84b3900eeb9dd2d95c553..fdb7d2e11576159885760d401f7c8e386f494b81 100644

--- a/src/heap.cc

+++ b/src/heap.cc

@@ -5720,7 +5720,7 @@ bool Heap::IdleNotification(int hint) {

AgeInlineCaches();

}

int mark_sweep_time = Min(TimeMarkSweepWouldTakeInMs(), 1000);

- if (hint >= mark_sweep_time && !FLAG_expose_gc &&

+ if (hint >= mark_sweep_time && !FLAG_expose_gc && !FLAG_expose_gc_as &&

incremental_marking()->IsStopped()) {

HistogramTimerScope scope(isolate_->counters()->gc_context());

CollectAllGarbage(kReduceMemoryFootprintMask,