src/extensions/gc-extension.h - Issue 14075012: Expose the GC under a name that is less collision prone than window.gc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/extensions/gc-extension.h

Issue 14075012: Expose the GC under a name that is less collision prone than window.gc. (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: --expose-gc-as Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/extensions/gc-extension.h

diff --git a/src/extensions/gc-extension.h b/src/extensions/gc-extension.h

index 06ea4ed21a63d40db4f1aebfd5acd165e675affe..c791561c8c2138a993128bb4455ff7a620058ad5 100644

--- a/src/extensions/gc-extension.h

+++ b/src/extensions/gc-extension.h

@@ -35,7 +35,7 @@ namespace internal {

class GCExtension : public v8::Extension {

public:

- GCExtension() : v8::Extension("v8/gc", kSource) {}

+ explicit GCExtension(const char* source) : v8::Extension("v8/gc", source) {}

virtual v8::Handle<v8::FunctionTemplate> GetNativeFunction(

v8::Handle<v8::String> name);

static v8::Handle<v8::Value> GC(const v8::Arguments& args);