Expose the GC under a name that is less collision prone than window.gc.

Expose the GC under a name that is less collision prone than window.gc.

This also keeps backwards compatibility (window.gc() still works).

BUG=2641
Committed: http://code.google.com/p/v8/source/detail?r=14397

[Michael Starzinger, 2013-04-22 11:42:03]

https://codereview.chromium.org/14075012/diff/1/src/extensions/gc-extension.cc
File src/extensions/gc-extension.cc (right):

https://codereview.chromium.org/14075012/diff/1/src/extensions/gc-extension.c...
src/extensions/gc-extension.cc:34: "native function v8_force_gc(); function gc()
{ v8_force_gc(); }";
This break the optional boolean argument that you can pass to gc() as well. The
correct delegation pattern is the following I think.

function gc() {
  return v8_force_gc.apply(this, arguments);
}

[marja, 2013-04-22 14:04:07]

fixed. could you land this?

https://codereview.chromium.org/14075012/diff/1/src/extensions/gc-extension.cc
File src/extensions/gc-extension.cc (right):

https://codereview.chromium.org/14075012/diff/1/src/extensions/gc-extension.c...
src/extensions/gc-extension.cc:34: "native function v8_force_gc(); function gc()
{ v8_force_gc(); }";
On 2013/04/22 11:42:03, Michael Starzinger wrote:
> This break the optional boolean argument that you can pass to gc() as well.
The
> correct delegation pattern is the following I think.
> 
> function gc() {
>   return v8_force_gc.apply(this, arguments);
> }

Done.

[Michael Starzinger, 2013-04-22 15:16:36]

As discussed offline, let's use an additional --expose-gc-as flag that allows
embedders to specify the function name.

[marja, 2013-04-22 15:28:37]

--expose-gc-as added

[Michael Starzinger, 2013-04-22 15:58:42]

LGTM with one nit. I will land this when the nits are addressed.

https://codereview.chromium.org/14075012/diff/4002/src/extensions/gc-extensio...
File src/extensions/gc-extension.cc (right):

https://codereview.chromium.org/14075012/diff/4002/src/extensions/gc-extensio...
src/extensions/gc-extension.cc:33: const char* const GCExtension::kSource =
"native function gc();";
This constant it no longer needed, let's drop it.

https://codereview.chromium.org/14075012/diff/4002/src/extensions/gc-extension.h
File src/extensions/gc-extension.h (right):

https://codereview.chromium.org/14075012/diff/4002/src/extensions/gc-extensio...
src/extensions/gc-extension.h:44: static const char* const kSource;
This constant it no longer needed, let's drop it.

[marja, 2013-04-23 11:06:02]

oops. fixed.

https://codereview.chromium.org/14075012/diff/4002/src/extensions/gc-extensio...
File src/extensions/gc-extension.cc (right):

https://codereview.chromium.org/14075012/diff/4002/src/extensions/gc-extensio...
src/extensions/gc-extension.cc:33: const char* const GCExtension::kSource =
"native function gc();";
On 2013/04/22 15:58:42, Michael Starzinger wrote:
> This constant it no longer needed, let's drop it.

Done.

[Michael Starzinger, 2013-04-23 16:30:58]

Committed patchset #9 manually as r14397 (presubmit successful).