Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 1407483003: Reland of [tracing] Display the locked size of discardable memory segment. (Closed)

Created:
5 years, 2 months ago by ssid
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, gavinp+memory_chromium.org, jam, Primiano Tucci (use gerrit), perezju
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of [tracing] Display the locked size of discardable memory segment. (patchset #1 id:1 of https://codereview.chromium.org/1386333003/ ) Reason for revert: Reland after the fix. The crash was due to IsMemoryLocked called for segments 0 which have no underlying shared memory, causing dcheck to fail. Fixed by removing not dumping the empty segments. Original issue's description: > Revert of [tracing] Display the locked size of discardable memory segment. (patchset #8 id:200001 of https://codereview.chromium.org/1374213002/ ) > > Reason for revert: > Speculative revert for the bug: www.crbug.com/541029 > > Original issue's description: > > [tracing] Display the locked size of discardable memory segment. > > > > The locked size of the discardable memory segments is now displayed on > > tracing. The browser side can only tell if the whole segment is locked > > or not, if the segment is shared with a child. The child side can also > > tell how much memory in the segment is locked. > > > > BUG=529943 > > > > Committed: https://crrev.com/a29f3c7b772a058c69b91d393740b85d7d23526b > > Cr-Commit-Position: refs/heads/master@{#352004} > > TBR=reveman@chromium.org,avi@chromium.org,thestig@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=529943 > > Committed: https://crrev.com/759242daa7de8683f62885673b5dfba75679727b > Cr-Commit-Position: refs/heads/master@{#353260} TBR=thestig@chromium.org BUG=529943 Committed: https://crrev.com/b16ac46e052b3daab95cd6518916579b80aecabb Cr-Commit-Position: refs/heads/master@{#353833}

Patch Set 1 : original patch #

Patch Set 2 : Fix. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -8 lines) Patch
M base/memory/discardable_shared_memory.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M base/memory/discardable_shared_memory.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M base/memory/discardable_shared_memory_unittest.cc View 1 5 chunks +10 lines, -1 line 0 comments Download
M content/child/child_discardable_shared_memory_manager.cc View 1 5 chunks +7 lines, -0 lines 0 comments Download
M content/common/discardable_shared_memory_heap.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M content/common/discardable_shared_memory_heap.cc View 1 4 chunks +18 lines, -7 lines 2 comments Download
M content/common/host_discardable_shared_memory_manager.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (3 generated)
ssid
Created Reland of [tracing] Display the locked size of discardable memory segment.
5 years, 2 months ago (2015-10-13 14:57:10 UTC) #1
ssid
reveman@ Can you take a look?
5 years, 2 months ago (2015-10-13 15:19:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407483003/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407483003/200001
5 years, 2 months ago (2015-10-13 16:00:36 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-13 18:05:43 UTC) #6
reveman
lgtm with nit but let's land this without changing that as it has passed the ...
5 years, 2 months ago (2015-10-13 18:24:33 UTC) #7
ssid
On 2015/10/13 18:24:33, reveman wrote: > lgtm with nit but let's land this without changing ...
5 years, 2 months ago (2015-10-13 18:47:57 UTC) #8
Avi (use Gerrit)
On 2015/10/13 18:47:57, ssid wrote: > On 2015/10/13 18:24:33, reveman wrote: > > lgtm with ...
5 years, 2 months ago (2015-10-13 19:37:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407483003/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407483003/200001
5 years, 2 months ago (2015-10-13 19:52:51 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:200001)
5 years, 2 months ago (2015-10-13 20:10:34 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 20:12:53 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b16ac46e052b3daab95cd6518916579b80aecabb
Cr-Commit-Position: refs/heads/master@{#353833}

Powered by Google App Engine
This is Rietveld 408576698