Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1407463003: Rebaseline some tests after Skia roll (Closed)

Created:
5 years, 2 months ago by Julien - ping for review
Modified:
5 years, 2 months ago
Reviewers:
herb_g, eae
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rebaseline some tests after Skia roll https://chromium.googlesource.com/skia/+/eb85b8321bc917169ba26c8fce76b64d2e3dfe81 changed how text baselines are computated, yielding to lowing the baseline position by 1px in orthogonal writing modes. NOTRY=true TBR=herb@google.com,eae@chromium.org Committed: https://crrev.com/db2bcd0927de728aa42947d1193c4e199ed1f763 Cr-Commit-Position: refs/heads/master@{#353897}

Patch Set 1 #

Messages

Total messages: 6 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407463003/1
5 years, 2 months ago (2015-10-13 23:05:09 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 23:19:15 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/db2bcd0927de728aa42947d1193c4e199ed1f763 Cr-Commit-Position: refs/heads/master@{#353897}
5 years, 2 months ago (2015-10-13 23:20:26 UTC) #4
herb_g
broken-ideograph-small-caps-expected.png seems to be missing for the new version? (about the 3rd to last.)
5 years, 2 months ago (2015-10-14 18:38:41 UTC) #5
herb_g
5 years, 2 months ago (2015-10-14 18:41:57 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698