Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1407443003: Non-SFI mode: Remove kUseNaClHelperNonSfi command line flag. (Closed)

Created:
5 years, 2 months ago by hidehiko
Modified:
5 years, 2 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews, hamaji, Junichi Uekawa
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Non-SFI mode: Remove kUseNaClHelperNonSfi command line flag. At M45, we switched the runtime for NaCl in Non-SFI mode from nacl_helper to nacl_helper_nonsfi, and it looks successfully done. This is the clean up CL for old runtime, which removes the command line flag. Note: CLs to clean up the build config/old source code will follow. BUG=539866 TEST=Ran ./browser_tests --gtest_filter=*PPAPI*:*NaCl*. Ran trybots. Committed: https://crrev.com/773ec42f7da988c21762c23fbceee3813749c545 Cr-Commit-Position: refs/heads/master@{#353789}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/common/nacl_paths.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M components/nacl/common/nacl_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/common/nacl_switches.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hidehiko
PTAL, Mark. This is for ensuring no one actually uses nacl_helper in Non-SFI mode. Remaining ...
5 years, 2 months ago (2015-10-13 10:14:28 UTC) #2
Mark Seaborn
LGTM, thanks
5 years, 2 months ago (2015-10-13 15:38:23 UTC) #3
hidehiko
On 2015/10/13 15:38:23, Mark Seaborn wrote: > LGTM, thanks Thank you for quick review. Submitting.
5 years, 2 months ago (2015-10-13 15:48:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407443003/1
5 years, 2 months ago (2015-10-13 16:00:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 18:17:16 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 18:18:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/773ec42f7da988c21762c23fbceee3813749c545
Cr-Commit-Position: refs/heads/master@{#353789}

Powered by Google App Engine
This is Rietveld 408576698