Remove old C++03 move emulation code.

remoting/base/typed_buffer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_BASE_TYPED_BUFFER_H_
 #define REMOTING_BASE_TYPED_BUFFER_H_
 
 #include <assert.h>
 
 #include <algorithm>
 
 #include "base/basictypes.h"
+#include "base/logging.h"
 #include "base/move.h"
 
 namespace remoting {
 
 // A scoper for a variable-length structure such as SID, SECURITY_DESCRIPTOR and
 // similar. These structures typically consist of a header followed by variable-
 // length data, so the size may not match sizeof(T). The class supports
 // move-only semantics and typed buffer getters.
 template <typename T>
 class TypedBuffer {
-  MOVE_ONLY_TYPE_FOR_CPP_03(TypedBuffer, RValue)
+  MOVE_ONLY_TYPE_FOR_CPP_03(TypedBuffer)
 
  public:
-  TypedBuffer() : buffer_(NULL), length_(0) {
-  }
+  TypedBuffer() : TypedBuffer(0) {}
 
   // Creates an instance of the object allocating a buffer of the given size.
   explicit TypedBuffer(uint32 length) : buffer_(NULL), length_(length) {
     if (length_ > 0)
       buffer_ = reinterpret_cast<T*>(new uint8[length_]);
   }
 
-  // Move constructor for C++03 move emulation of this type.
-  TypedBuffer(RValue rvalue) : buffer_(NULL), length_(0) {
-    TypedBuffer temp;

[dcheng, 2015/10/13 21:03:09]

I'm not quite sure what the purpose of the temp here is: it should be possible
to self-move in a move constructor.

[dcheng, 2015/10/13 21:03:39]

should *not* be possible

-    temp.Swap(*rvalue.object);
-    Swap(temp);
-  }
+  TypedBuffer(TypedBuffer&& rvalue) : TypedBuffer() { Swap(rvalue); }
 
   ~TypedBuffer() {
     if (buffer_) {
       delete[] reinterpret_cast<uint8*>(buffer_);
       buffer_ = NULL;
     }
   }
 
-  // Move operator= for C++03 move emulation of this type.
-  TypedBuffer& operator=(RValue rvalue) {
-    TypedBuffer temp;

[dcheng, 2015/10/13 21:03:09]

I opted to just DCHECK that this is not a self-move.

-    temp.Swap(*rvalue.object);
-    Swap(temp);
+  TypedBuffer& operator=(TypedBuffer&& rvalue) {
+    DCHECK_NE(this, &rvalue);

[danakj, 2015/10/15 23:35:06]

Swap would handle *this ok? No dcheck?

[dcheng, 2015/10/16 00:40:01]

Done.

+    Swap(rvalue);
     return *this;
   }
 
   // Accessors to get the owned buffer.
   // operator* and operator-> will assert() if there is no current buffer.
   T& operator*() const {
     assert(buffer_ != NULL);
     return *buffer_;
   }
   T* operator->() const  {
@@ skipping 25 matching lines @@
   // Points to the owned buffer.
   T* buffer_;
 
   // Length of the owned buffer in bytes.
   uint32 length_;
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_BASE_TYPED_BUFFER_H_