Remove old C++03 move emulation code.

chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/spellchecker/spellcheck_hunspell_dictionary.h"
 
 #include "base/files/file_util.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "base/path_service.h"
@@ skipping 61 matching lines @@
 
 SpellcheckHunspellDictionary::DictionaryFile::~DictionaryFile() {
   if (file.IsValid()) {
     BrowserThread::PostTask(
         BrowserThread::FILE,
         FROM_HERE,
         base::Bind(&CloseDictionary, Passed(&file)));
   }
 }
 
-SpellcheckHunspellDictionary::DictionaryFile::DictionaryFile(RValue other)
-    : path(other.object->path),
-      file(other.object->file.Pass()) {
-}
+SpellcheckHunspellDictionary::DictionaryFile::DictionaryFile(
+    DictionaryFile&& other)
+    : path(other.path), file(other.file.Pass()) {}
 
 SpellcheckHunspellDictionary::DictionaryFile&
-SpellcheckHunspellDictionary::DictionaryFile::operator=(RValue other) {
-  if (this != other.object) {
-    path = other.object->path;
-    file = other.object->file.Pass();
-  }
+    SpellcheckHunspellDictionary::DictionaryFile::
+    operator=(DictionaryFile&& other) {
+  DCHECK_NE(this, &other);

[danakj, 2015/10/15 23:35:06]

this looks non-destructive, can we remove the dcheck? or not i don't super mind
a DCHECK either.

[dcheng, 2015/10/16 00:40:01]

  file = other.file.Pass()

is destructive.

That being said, File::operator=(File&&) will DCHECK on a self-move here. So the
question is if it's OK for a class embedding a type to depend on the fact that a
self-move of the other type should/will DCHECK. My sense is probably? But I want
to confirm before actually making this change.

[danakj, 2015/10/16 00:44:24]

I think that's the right way to do it ya.

[dcheng, 2015/10/19 21:29:50]

Done.

+  path = other.path;
+  file = other.file.Pass();
   return *this;
 }
 
 SpellcheckHunspellDictionary::SpellcheckHunspellDictionary(
     const std::string& language,
     net::URLRequestContextGetter* request_context_getter,
     SpellcheckService* spellcheck_service)
     : language_(language),
       use_browser_spellchecker_(false),
       request_context_getter_(request_context_getter),
@@ skipping 265 matching lines @@
   FOR_EACH_OBSERVER(Observer, observers_,
                     OnHunspellDictionaryInitialized(language_));
 }
 
 void SpellcheckHunspellDictionary::InformListenersOfDownloadFailure() {
   download_status_ = DOWNLOAD_FAILED;
   FOR_EACH_OBSERVER(Observer,
                     observers_,
                     OnHunspellDictionaryDownloadFailure(language_));
 }