Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: remoting/base/typed_buffer.h

Issue 1407443002: Remove old C++03 move emulation code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: std::move and reflow Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/base/file_stream_context.cc ('k') | storage/browser/blob/scoped_file.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef REMOTING_BASE_TYPED_BUFFER_H_ 5 #ifndef REMOTING_BASE_TYPED_BUFFER_H_
6 #define REMOTING_BASE_TYPED_BUFFER_H_ 6 #define REMOTING_BASE_TYPED_BUFFER_H_
7 7
8 #include <assert.h> 8 #include <assert.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
11 11
12 #include "base/basictypes.h" 12 #include "base/basictypes.h"
13 #include "base/logging.h"
13 #include "base/move.h" 14 #include "base/move.h"
14 15
15 namespace remoting { 16 namespace remoting {
16 17
17 // A scoper for a variable-length structure such as SID, SECURITY_DESCRIPTOR and 18 // A scoper for a variable-length structure such as SID, SECURITY_DESCRIPTOR and
18 // similar. These structures typically consist of a header followed by variable- 19 // similar. These structures typically consist of a header followed by variable-
19 // length data, so the size may not match sizeof(T). The class supports 20 // length data, so the size may not match sizeof(T). The class supports
20 // move-only semantics and typed buffer getters. 21 // move-only semantics and typed buffer getters.
21 template <typename T> 22 template <typename T>
22 class TypedBuffer { 23 class TypedBuffer {
23 MOVE_ONLY_TYPE_FOR_CPP_03(TypedBuffer, RValue) 24 MOVE_ONLY_TYPE_FOR_CPP_03(TypedBuffer)
24 25
25 public: 26 public:
26 TypedBuffer() : buffer_(NULL), length_(0) { 27 TypedBuffer() : TypedBuffer(0) {}
27 }
28 28
29 // Creates an instance of the object allocating a buffer of the given size. 29 // Creates an instance of the object allocating a buffer of the given size.
30 explicit TypedBuffer(uint32 length) : buffer_(NULL), length_(length) { 30 explicit TypedBuffer(uint32 length) : buffer_(NULL), length_(length) {
31 if (length_ > 0) 31 if (length_ > 0)
32 buffer_ = reinterpret_cast<T*>(new uint8[length_]); 32 buffer_ = reinterpret_cast<T*>(new uint8[length_]);
33 } 33 }
34 34
35 // Move constructor for C++03 move emulation of this type. 35 TypedBuffer(TypedBuffer&& rvalue) : TypedBuffer() { Swap(rvalue); }
36 TypedBuffer(RValue rvalue) : buffer_(NULL), length_(0) {
37 TypedBuffer temp;
38 temp.Swap(*rvalue.object);
39 Swap(temp);
40 }
41 36
42 ~TypedBuffer() { 37 ~TypedBuffer() {
43 if (buffer_) { 38 if (buffer_) {
44 delete[] reinterpret_cast<uint8*>(buffer_); 39 delete[] reinterpret_cast<uint8*>(buffer_);
45 buffer_ = NULL; 40 buffer_ = NULL;
46 } 41 }
47 } 42 }
48 43
49 // Move operator= for C++03 move emulation of this type. 44 TypedBuffer& operator=(TypedBuffer&& rvalue) {
50 TypedBuffer& operator=(RValue rvalue) { 45 Swap(rvalue);
51 TypedBuffer temp;
52 temp.Swap(*rvalue.object);
53 Swap(temp);
54 return *this; 46 return *this;
55 } 47 }
56 48
57 // Accessors to get the owned buffer. 49 // Accessors to get the owned buffer.
58 // operator* and operator-> will assert() if there is no current buffer. 50 // operator* and operator-> will assert() if there is no current buffer.
59 T& operator*() const { 51 T& operator*() const {
60 assert(buffer_ != NULL); 52 assert(buffer_ != NULL);
61 return *buffer_; 53 return *buffer_;
62 } 54 }
63 T* operator->() const { 55 T* operator->() const {
(...skipping 25 matching lines...) Expand all
89 // Points to the owned buffer. 81 // Points to the owned buffer.
90 T* buffer_; 82 T* buffer_;
91 83
92 // Length of the owned buffer in bytes. 84 // Length of the owned buffer in bytes.
93 uint32 length_; 85 uint32 length_;
94 }; 86 };
95 87
96 } // namespace remoting 88 } // namespace remoting
97 89
98 #endif // REMOTING_BASE_TYPED_BUFFER_H_ 90 #endif // REMOTING_BASE_TYPED_BUFFER_H_
OLDNEW
« no previous file with comments | « net/base/file_stream_context.cc ('k') | storage/browser/blob/scoped_file.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698