Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: chrome/chrome_installer_util.gypi

Issue 1407433005: Enable /Zc:StrictStrings on release builds Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix formatting Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'target_defaults': { 6 'target_defaults': {
7 'variables': { 7 'variables': {
8 'installer_util_target': 0, 8 'installer_util_target': 0,
9 }, 9 },
10 'conditions': [
11 ['OS=="win"', {
12 # As of the Windows 10 SDK WbemDisp.h still contains many function
13 # prototypes with BSTR strObjectPath = L"" which /Zc:StrictStrings
14 # rightly rejects, and WbemDisp.h is required by some chrome installer
15 # components.
16 'msvs_settings': {
17 'VCCLCompilerTool': {
18 'AdditionalOptions!': [ '/Zc:strictStrings' ]
19 },
20 },
21 }],
22 ],
10 'target_conditions': [ 23 'target_conditions': [
11 # This part is shared between the two versions of the target. 24 # This part is shared between the two versions of the target.
12 ['installer_util_target==1', { 25 ['installer_util_target==1', {
13 'sources': [ 26 'sources': [
14 'installer/util/advanced_firewall_manager_win.cc', 27 'installer/util/advanced_firewall_manager_win.cc',
15 'installer/util/advanced_firewall_manager_win.h', 28 'installer/util/advanced_firewall_manager_win.h',
16 'installer/util/app_command.cc', 29 'installer/util/app_command.cc',
17 'installer/util/app_command.h', 30 'installer/util/app_command.h',
18 'installer/util/app_commands.cc', 31 'installer/util/app_commands.cc',
19 'installer/util/app_commands.h', 32 'installer/util/app_commands.h',
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 ], 235 ],
223 'include_dirs': [ 236 'include_dirs': [
224 '<(DEPTH)', 237 '<(DEPTH)',
225 ], 238 ],
226 } 239 }
227 ], 240 ],
228 }], 241 }],
229 242
230 ], 243 ],
231 } 244 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698