content/browser/service_worker/service_worker_dispatcher_host_unittest.cc - Issue 140743012: Start EmbeddedWorker during registration - take 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

Issue 140743012: Start EmbeddedWorker during registration - take 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Clean up existing registration case Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_dispatcher_host.cc ('K') | « content/browser/service_worker/service_worker_dispatcher_host.cc ('k') | content/browser/service_worker/service_worker_job_coordinator.h » ('j') | content/browser/service_worker/service_worker_job_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

diff --git a/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc b/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

index 8d5b39d40e1284b26845c23dbaa96b7cee210ae1..7881a70ec7f67e8def42abfa4c33ec6ac5c500c1 100644

--- a/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

+++ b/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

@@ -78,7 +78,7 @@ TEST_F(ServiceWorkerDispatcherHostTest, DisabledCausesError) {

bool handled;

dispatcher_host->OnMessageReceived(

- ServiceWorkerHostMsg_RegisterServiceWorker(-1, -1, GURL(), GURL()),

+ ServiceWorkerHostMsg_RegisterServiceWorker(-1, -1, -1, GURL(), GURL()),

&handled);

EXPECT_TRUE(handled);

@@ -101,7 +101,7 @@ TEST_F(ServiceWorkerDispatcherHostTest, Enabled) {

bool handled;

dispatcher_host->OnMessageReceived(

- ServiceWorkerHostMsg_RegisterServiceWorker(-1, -1, GURL(), GURL()),

+ ServiceWorkerHostMsg_RegisterServiceWorker(-1, -1, -1, GURL(), GURL()),

&handled);

EXPECT_TRUE(handled);

base::RunLoop().RunUntilIdle();

@@ -127,7 +127,7 @@ TEST_F(ServiceWorkerDispatcherHostTest, EarlyContextDeletion) {

bool handled;

dispatcher_host->OnMessageReceived(

- ServiceWorkerHostMsg_RegisterServiceWorker(-1, -1, GURL(), GURL()),

+ ServiceWorkerHostMsg_RegisterServiceWorker(-1, -1, -1, GURL(), GURL()),

&handled);

EXPECT_TRUE(handled);