Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 140743011: New home page for developer.chrome.com (Closed)

Created:
6 years, 11 months ago by mkearney1
Modified:
6 years, 11 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, vsevik, tzik, yurys, paulirish+reviews_chromium.org, nhiroki, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, kinuko+watch, aandrey+blink_chromium.org, pfeldman
Visibility:
Public.

Description

New home page for developer.chrome.com And pillar pages for DevTools, Multi-device, and Platform. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246213

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : OWNERS file #

Patch Set 8 : Removed OWNERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+772 lines, -39 lines) Patch
M chrome/common/extensions/docs/static/css/out/site.css View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A chrome/common/extensions/docs/static/images/devtools-pillar/console-pillar.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/devtools-pillar/cpuprofiler-pillar.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/devtools-pillar/dom-pillar.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/devtools-pillar/emulation-pillar.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/devtools-pillar/flamechart-pillar.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/devtools-pillar/jsdebugger-pillar.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/devtools-pillar/memory-pillar.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/devtools-pillar/remote-debugging-pillar.jpg View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/devtools-pillar/timeline-pillar.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/mocks/remote-debug-overview.jpg View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/mocks/webview_video_thumb.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/multi-device-pillar/addtohomescreen.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/multi-device-pillar/multidevice.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/multi-device-pillar/webview_gs.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/multi-device-pillar/workflow.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/platform-pillar/ChromeWebStore_BadgeWBorder_v2_206x58.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/platform-pillar/chrome_app_samples.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/platform-pillar/chrome_apps.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/platform-pillar/chrome_web_store.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/platform-pillar/extension_samples.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/platform-pillar/extensions.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/platform-pillar/one_click_kittens.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/platform-pillar/pnacl_intro.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/platform-pillar/store_developer_dashboard.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/platform-pillar/sync_file_system.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/platform-pillar/theme.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/platform-pillar/todo_codelab.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/platform-pillar/upload_extensions.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/platform-pillar/wallet-review.png View Binary file 0 comments Download
M chrome/common/extensions/docs/static/sass/_homepage.scss View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/static/sass/_html.scss View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/static/sass/_navbar.scss View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/static/sass/_pillar.scss View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A chrome/docs/devtools-pillar.html View 1 2 3 4 1 chunk +234 lines, -0 lines 0 comments Download
M chrome/docs/index.html View 1 2 3 4 3 chunks +56 lines, -32 lines 0 comments Download
A chrome/docs/multi-device-pillar.html View 1 chunk +96 lines, -0 lines 0 comments Download
A chrome/docs/platform-pillar.html View 1 1 chunk +375 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mkearney1
Hi, guys Hoping to land this quick (and make edits as review comments come back ...
6 years, 11 months ago (2014-01-20 19:57:33 UTC) #1
Renato Mangini (chromium)
Aside from my comment about clickable headers and images, lgtm. https://codereview.chromium.org/140743011/diff/510001/chrome/docs/index.html File chrome/docs/index.html (left): https://codereview.chromium.org/140743011/diff/510001/chrome/docs/index.html#oldcode8 ...
6 years, 11 months ago (2014-01-21 18:52:03 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 11 months ago (2014-01-21 19:51:40 UTC) #3
not at google - send to devlin
lgtm, add OWNERS file in chrome/docs sometime.
6 years, 11 months ago (2014-01-21 19:53:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkearney@chromium.org/140743011/1220001
6 years, 11 months ago (2014-01-21 19:56:24 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=45680
6 years, 11 months ago (2014-01-21 20:15:14 UTC) #6
mkearney1
James, We are trying to land new home and pillar pages for developer.chrome.com (which will ...
6 years, 11 months ago (2014-01-21 20:59:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkearney@chromium.org/140743011/1280002
6 years, 11 months ago (2014-01-21 23:45:04 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-22 02:13:02 UTC) #9
Message was sent while issue was closed.
Change committed as 246213

Powered by Google App Engine
This is Rietveld 408576698