Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 140743010: Get rid of dynamic call debug stub (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/stub_code_ia32.cc
===================================================================
--- runtime/vm/stub_code_ia32.cc (revision 31928)
+++ runtime/vm/stub_code_ia32.cc (working copy)
@@ -1861,36 +1861,6 @@
}
-// ECX: Inline cache data array.
-// TOS(0): return address (Dart code).
-void StubCode::GenerateBreakpointDynamicStub(Assembler* assembler) {
- // Create a stub frame as we are pushing some objects on the stack before
- // calling into the runtime.
- __ EnterStubFrame();
- __ pushl(ECX);
- __ CallRuntime(kBreakpointDynamicHandlerRuntimeEntry, 0);
- __ popl(ECX);
- __ LeaveFrame();
-
- // Find out which dispatch stub to call.
- Label test_two, test_three, test_four;
- __ movl(EBX, FieldAddress(ECX, ICData::num_args_tested_offset()));
- __ cmpl(EBX, Immediate(1));
- __ j(NOT_EQUAL, &test_two, Assembler::kNearJump);
- __ jmp(&StubCode::OneArgCheckInlineCacheLabel());
- __ Bind(&test_two);
- __ cmpl(EBX, Immediate(2));
- __ j(NOT_EQUAL, &test_three, Assembler::kNearJump);
- __ jmp(&StubCode::TwoArgsCheckInlineCacheLabel());
- __ Bind(&test_three);
- __ cmpl(EBX, Immediate(3));
- __ j(NOT_EQUAL, &test_four, Assembler::kNearJump);
- __ jmp(&StubCode::ThreeArgsCheckInlineCacheLabel());
- __ Bind(&test_four);
- __ Stop("Unsupported number of arguments tested.");
-}
-
-
// Called only from unoptimized code.
void StubCode::GenerateDebugStepCheckStub(Assembler* assembler) {
// Check single stepping.

Powered by Google App Engine
This is Rietveld 408576698