Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1407423004: Fix all relative includes to core. (Closed)

Created:
5 years, 1 month ago by Lei Zhang
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix all relative includes to core. Do some IWYU to fix build errors due to files that have no #includes but just happened to work previously because the #includes were in the right order. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/9e7cd8ffb81c564e1102f6c6459ec0942a0b11ea

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -87 lines) Patch
M core/src/fxcodec/jbig2/JBig2_HuffmanTable_Standard.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/formfiller/FFL_ComboBox.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/formfiller/FormFiller.h View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/fsdk_actionhandler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/fsdk_annothandler.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fsdk_baseannot.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/fsdk_baseform.h View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/include/fsdk_define.h View 1 chunk +10 lines, -10 lines 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fx_systemhandler.h View 1 chunk +7 lines, -0 lines 0 comments Download
M fpdfsdk/include/fxedit/fx_edit.h View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/fxedit/fxet_edit.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fxedit/fxet_list.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fxedit/fxet_stub.h View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/include/javascript/IJavaScript.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/jsapi/fxjs_v8.h View 1 chunk +2 lines, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PDFWindow.h View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Edit.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_EditCtrl.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Icon.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_IconList.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Utils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Wnd.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdf_ext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_searchex.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfdoc_embeddertest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdftext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Context.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/JS_EventHandler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/JS_GlobalData.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_GlobalData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Value.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 2 chunks +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/resource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Edit.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M testing/fx_string_testhelpers.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/agg23/agg_array.h View 1 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/agg23/agg_basics.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/agg23/agg_curves.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/agg23/agg_path_storage.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/agg23/agg_rasterizer_scanline_aa.h View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/agg23/agg_vcgen_dash.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/agg23/agg_vcgen_stroke.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/lcms2-2.6/src/cmserr.c View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/libjpeg/jinclude.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/zlib_v128/zutil.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Lei Zhang
The files that are not just +N/-N are probably worth looking at.
5 years, 1 month ago (2015-11-06 22:37:49 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1407423004/diff/1/third_party/agg23/agg_array.h File third_party/agg23/agg_array.h (right): https://codereview.chromium.org/1407423004/diff/1/third_party/agg23/agg_array.h#newcode20 third_party/agg23/agg_array.h:20: #include "core/include/fxcrt/fx_memory.h" // For FXSYS_foo. nit: how about ...
5 years, 1 month ago (2015-11-06 22:49:50 UTC) #3
Lei Zhang
https://codereview.chromium.org/1407423004/diff/1/third_party/agg23/agg_array.h File third_party/agg23/agg_array.h (right): https://codereview.chromium.org/1407423004/diff/1/third_party/agg23/agg_array.h#newcode20 third_party/agg23/agg_array.h:20: #include "core/include/fxcrt/fx_memory.h" // For FXSYS_foo. On 2015/11/06 22:49:50, Tom ...
5 years, 1 month ago (2015-11-06 23:55:24 UTC) #4
Lei Zhang
5 years, 1 month ago (2015-11-06 23:56:32 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
9e7cd8ffb81c564e1102f6c6459ec0942a0b11ea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698