 Chromium Code Reviews
 Chromium Code Reviews Issue 1407413014:
  [turbofan] Pseudo-inline instanceof  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master
    
  
    Issue 1407413014:
  [turbofan] Pseudo-inline instanceof  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master| Index: test/cctest/compiler/test-js-typed-lowering.cc | 
| diff --git a/test/cctest/compiler/test-js-typed-lowering.cc b/test/cctest/compiler/test-js-typed-lowering.cc | 
| index cc799448d3b03a254eb63a7ed0169b72f061afed..1217e65c2805b7ad737101a3873c54cdf188d3d1 100644 | 
| --- a/test/cctest/compiler/test-js-typed-lowering.cc | 
| +++ b/test/cctest/compiler/test-js-typed-lowering.cc | 
| @@ -14,6 +14,7 @@ | 
| #include "src/compiler/simplified-operator.h" | 
| #include "src/compiler/typer.h" | 
| #include "test/cctest/cctest.h" | 
| +#include "test/cctest/compiler/function-tester.h" | 
| 
Michael Starzinger
2015/11/10 09:48:48
nit: Include no longer needed.
 
sigurds
2015/11/10 10:01:24
Done.
 | 
| namespace v8 { | 
| namespace internal { | 
| @@ -42,6 +43,7 @@ class JSTypedLoweringTester : public HandleAndZoneScope { | 
| machine(main_zone()), | 
| simplified(main_zone()), | 
| common(main_zone()), | 
| + deps(main_isolate(), main_zone()), | 
| graph(main_zone()), | 
| typer(main_isolate(), &graph), | 
| context_node(NULL) { | 
| @@ -57,6 +59,7 @@ class JSTypedLoweringTester : public HandleAndZoneScope { | 
| MachineOperatorBuilder machine; | 
| SimplifiedOperatorBuilder simplified; | 
| CommonOperatorBuilder common; | 
| + CompilationDependencies deps; | 
| Graph graph; | 
| Typer typer; | 
| Node* context_node; | 
| @@ -94,7 +97,9 @@ class JSTypedLoweringTester : public HandleAndZoneScope { | 
| &machine); | 
| // TODO(titzer): mock the GraphReducer here for better unit testing. | 
| GraphReducer graph_reducer(main_zone(), &graph); | 
| - JSTypedLowering reducer(&graph_reducer, &jsgraph, main_zone()); | 
| + JSTypedLowering reducer(&graph_reducer, &deps, | 
| + JSTypedLowering::kDeoptimizationEnabled, &jsgraph, | 
| + main_zone()); | 
| Reduction reduction = reducer.Reduce(node); | 
| if (reduction.Changed()) return reduction.replacement(); | 
| return node; | 
| @@ -129,6 +134,7 @@ class JSTypedLoweringTester : public HandleAndZoneScope { | 
| Node* Binop(const Operator* op, Node* left, Node* right) { | 
| // JS binops also require context, effect, and control | 
| + DCHECK_EQ(op->ValueInputCount(), 2); | 
| 
Michael Starzinger
2015/11/10 09:48:48
nit: Change no longer needed, let's drop it.
 
sigurds
2015/11/10 10:01:24
Done.
 | 
| std::vector<Node*> inputs; | 
| inputs.push_back(left); | 
| inputs.push_back(right); |