[turbofan] Pseudo-inline instanceof

test/unittests/compiler/js-typed-lowering-unittest.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/code-factory.h"
 #include "src/compiler/access-builder.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/js-operator.h"
 #include "src/compiler/js-typed-lowering.h"
 #include "src/compiler/machine-operator.h"
@@ skipping 56 matching lines @@
 
 
 STATIC_ASSERT(LANGUAGE_END == 3);
 const LanguageMode kLanguageModes[] = {SLOPPY, STRICT, STRONG};
 
 }  // namespace
 
 
 class JSTypedLoweringTest : public TypedGraphTest {
  public:
-  JSTypedLoweringTest() : TypedGraphTest(3), javascript_(zone()) {}
+  JSTypedLoweringTest()
+      : TypedGraphTest(3), javascript_(zone()), deps_(isolate(), zone()) {}
   ~JSTypedLoweringTest() override {}
 
  protected:
   Reduction Reduce(Node* node) {
     MachineOperatorBuilder machine(zone());
     SimplifiedOperatorBuilder simplified(zone());
     JSGraph jsgraph(isolate(), graph(), common(), javascript(), &simplified,
                     &machine);
     // TODO(titzer): mock the GraphReducer here for better unit testing.
     GraphReducer graph_reducer(zone(), graph());
-    JSTypedLowering reducer(&graph_reducer, &jsgraph, zone());
+    JSTypedLowering reducer(&graph_reducer, &deps_,
+                            JSTypedLowering::kDeoptimizationEnabled, &jsgraph,
+                            zone());
     return reducer.Reduce(node);
   }
 
   Node* FrameState(Handle<SharedFunctionInfo> shared, Node* outer_frame_state) {
     Node* state_values = graph()->NewNode(common()->StateValues(0));
     return graph()->NewNode(
         common()->FrameState(BailoutId::None(),
                              OutputFrameStateCombine::Ignore(),
                              common()->CreateFrameStateFunctionInfo(
                                  FrameStateType::kJavaScriptFunction, 1, 0,
@@ skipping 10 matching lines @@
 
   Matcher<Node*> IsIntPtrConstant(intptr_t value) {
     return sizeof(value) == 4 ? IsInt32Constant(static_cast<int32_t>(value))
                               : IsInt64Constant(static_cast<int64_t>(value));
   }
 
   JSOperatorBuilder* javascript() { return &javascript_; }
 
  private:
   JSOperatorBuilder javascript_;
+  CompilationDependencies deps_;
 };
 
 
 // -----------------------------------------------------------------------------
 // JSUnaryNot
 
 
 TEST_F(JSTypedLoweringTest, JSUnaryNotWithBoolean) {
   Node* input = Parameter(Type::Boolean(), 0);
   Node* context = Parameter(Type::Any(), 1);
@@ skipping 1032 matching lines @@
       Reduce(graph()->NewNode(javascript()->CreateWithContext(), object,
                               closure, context, frame_state, effect, control));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(r.replacement(),
               IsFinishRegion(IsAllocate(IsNumberConstant(Context::SizeFor(
                                             Context::MIN_CONTEXT_SLOTS)),
                                         IsBeginRegion(effect), control),
                              _));
 }
 
+
+// -----------------------------------------------------------------------------
+// InstanceOf

[Michael Starzinger, 2015/11/10 09:48:48]

nit: s/InstanceOf/JSInstanceOf

[sigurds, 2015/11/10 10:01:24]

Done.

+// Test that instanceOf is reduced if and only if the right-hand side is a
+// function constant. Functional correctness is ensured elsewhere.
+
+
+TEST_F(JSTypedLoweringTest, InstanceOfSpecialization) {

[Michael Starzinger, 2015/11/10 09:48:48]

nit: Let's split this into three separate unit test cases. I like that fact that
our unit test are as simple and as minimal as possible.

[Michael Starzinger, 2015/11/10 09:49:49]

nit: s/InstanceOfSpecialization/JSInstanceOf/ here as well.

[sigurds, 2015/11/10 10:01:24]

Done.

[sigurds, 2015/11/10 10:01:24]

Done.

+  Node* const context = Parameter(Type::Any());
+  Node* const frame_state = EmptyFrameState();
+  Node* const effect = graph()->start();
+  Node* const control = graph()->start();
+
+  // Reduce if left-hand side is known to be an object.
+  Node* instanceOf =
+      graph()->NewNode(javascript()->InstanceOf(), Parameter(Type::Object(), 0),
+                       HeapConstant(isolate()->object_function()), context,
+                       frame_state, effect, control);
+  Node* dummy = graph()->NewNode(javascript()->ToObject(), instanceOf, context,
+                                 frame_state, effect, control);
+  Reduction r = Reduce(instanceOf);
+  ASSERT_TRUE(r.Changed());
+  ASSERT_EQ(r.replacement(), dummy->InputAt(0));
+  ASSERT_NE(instanceOf, dummy->InputAt(0));
+
+  // Reduce if left-hand side could be a Smi.
+  instanceOf =
+      graph()->NewNode(javascript()->InstanceOf(), Parameter(Type::Any(), 0),
+                       HeapConstant(isolate()->object_function()), context,
+                       frame_state, effect, control);
+  dummy = graph()->NewNode(javascript()->ToObject(), instanceOf, context,
+                           frame_state, effect, control);
+  r = Reduce(instanceOf);
+  ASSERT_TRUE(r.Changed());
+  ASSERT_EQ(r.replacement(), dummy->InputAt(0));
+  ASSERT_NE(instanceOf, dummy->InputAt(0));
+
+  // Do not reduce if right-hand side is not a function constant.
+  instanceOf = graph()->NewNode(
+      javascript()->InstanceOf(), Parameter(Type::Any(), 0),
+      Parameter(Type::Any()), context, frame_state, effect, control);
+  dummy = graph()->NewNode(javascript()->ToObject(), instanceOf, context,
+                           frame_state, effect, control);
+  r = Reduce(instanceOf);
+  ASSERT_FALSE(r.Changed());
+  ASSERT_EQ(instanceOf, dummy->InputAt(0));
+}
+
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8