[turbofan] Pseudo-inline instanceof

test/cctest/compiler/test-js-typed-lowering.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(jochen): Remove this after the setting is turned on globally.
 #define V8_IMMINENT_DEPRECATION_WARNINGS
 
 #include "src/compiler/js-graph.h"
 #include "src/compiler/js-typed-lowering.h"
 #include "src/compiler/machine-operator.h"
 #include "src/compiler/node-properties.h"
 #include "src/compiler/opcodes.h"
 #include "src/compiler/operator-properties.h"
 #include "src/compiler/simplified-operator.h"
 #include "src/compiler/typer.h"
 #include "test/cctest/cctest.h"
+#include "test/cctest/compiler/function-tester.h"
 
 namespace v8 {
 namespace internal {
 namespace compiler {
 
 #ifndef TEST_WITH_STRONG
 #define TEST_WITH_STRONG(Name)                                                 \
   static void Test##Name();                                                    \
   static void TestWithStrong##Name(LanguageMode language_mode);                \
   CcTest register_test_##Name(Test##Name, __FILE__, #Name, NULL, true, true);  \
   static void Test##Name() {                                                   \
     TestWithStrong##Name(LanguageMode::SLOPPY);                                \
     TestWithStrong##Name(LanguageMode::STRONG);                                \
   }                                                                            \
   static void TestWithStrong##Name(LanguageMode language_mode)
 #endif
 
 
 class JSTypedLoweringTester : public HandleAndZoneScope {
  public:
   explicit JSTypedLoweringTester(int num_parameters = 0)
       : isolate(main_isolate()),
         binop(NULL),
         unop(NULL),
         javascript(main_zone()),
         machine(main_zone()),
         simplified(main_zone()),
         common(main_zone()),
+        deps(main_isolate(), main_zone()),
         graph(main_zone()),
         typer(main_isolate(), &graph),
         context_node(NULL) {
     graph.SetStart(graph.NewNode(common.Start(num_parameters)));
     graph.SetEnd(graph.NewNode(common.End(1), graph.start()));
     typer.Run();
   }
 
   Isolate* isolate;
   const Operator* binop;
   const Operator* unop;
   JSOperatorBuilder javascript;
   MachineOperatorBuilder machine;
   SimplifiedOperatorBuilder simplified;
   CommonOperatorBuilder common;
+  CompilationDependencies deps;
   Graph graph;
   Typer typer;
   Node* context_node;
 
   Node* Parameter(Type* t, int32_t index = 0) {
     Node* n = graph.NewNode(common.Parameter(index), graph.start());
     NodeProperties::SetType(n, t);
     return n;
   }
 
@@ skipping 17 matching lines @@
         parameters, locals, stack, context, UndefinedConstant(), graph.start());
 
     return state_node;
   }
 
   Node* reduce(Node* node) {
     JSGraph jsgraph(main_isolate(), &graph, &common, &javascript, &simplified,
                     &machine);
     // TODO(titzer): mock the GraphReducer here for better unit testing.
     GraphReducer graph_reducer(main_zone(), &graph);
-    JSTypedLowering reducer(&graph_reducer, &jsgraph, main_zone());
+    JSTypedLowering reducer(&graph_reducer, &deps, &jsgraph, main_zone());
     Reduction reduction = reducer.Reduce(node);
     if (reduction.Changed()) return reduction.replacement();
     return node;
   }
 
   Node* start() { return graph.start(); }
 
   Node* context() {
     if (context_node == NULL) {
       context_node = graph.NewNode(common.Parameter(-1), graph.start());
@@ skipping 14 matching lines @@
   Node* ReduceUnop(const Operator* op, Type* input_type) {
     return reduce(Unop(op, Parameter(input_type)));
   }
 
   Node* ReduceBinop(const Operator* op, Type* left_type, Type* right_type) {
     return reduce(Binop(op, Parameter(left_type, 0), Parameter(right_type, 1)));
   }
 
   Node* Binop(const Operator* op, Node* left, Node* right) {
     // JS binops also require context, effect, and control
+    DCHECK_EQ(op->ValueInputCount(), 2);
     std::vector<Node*> inputs;
     inputs.push_back(left);
     inputs.push_back(right);
     if (OperatorProperties::HasContextInput(op)) {
       inputs.push_back(context());
     }
     for (int i = 0; i < OperatorProperties::GetFrameStateInputCount(op); i++) {
       inputs.push_back(EmptyFrameState(context()));
     }
     if (op->EffectInputCount() > 0) {
@@ skipping 1115 matching lines @@
           CHECK_EQ(p0, r->InputAt(1));
         } else {
           CHECK_EQ(p0, r->InputAt(0));
           CHECK_EQ(p1, r->InputAt(1));
         }
       }
     }
   }
 }
 
+
+// Test that instanceOf is reduced if and only if the right-hand side is a
+// function constant. Functional correctness is ensured elsewhere.
+TEST(InstanceOfSpecialization) {

[Michael Starzinger, 2015/11/09 19:59:59]

Since these tests only check that "something is reduced", I would vote for
turning them into real unit tests and moving them into
js-typed-lowering-unittest.cc. The FunctionTester is not needed, for the
constant function you can just use "isolate->object_function()" for example.

[sigurds, 2015/11/10 09:39:44]

Done.

+  JSTypedLoweringTester R;
+  FunctionTester F(
+      "(function (){"
+      " return function Bar(x){"
+      "    this.x= x;"
+      "  }"
+      "})();");
+
+  // Reduce if left-hand side is known to be an object.
+  Node* instanceOf =
+      R.Binop(R.javascript.InstanceOf(), R.Parameter(Type::Object(), 0),
+              R.HeapConstant(F.function));
+  Node* dummy = R.Unop(R.javascript.ToObject(), instanceOf);
+  Node* replacement = R.reduce(instanceOf);
+  CHECK(IrOpcode::IsPhiOpcode(replacement->opcode()));
+  CHECK_EQ(replacement, dummy->InputAt(0));
+  CHECK_NE(instanceOf, dummy->InputAt(0));
+
+  // Reduce if left-hand side could be a Smi.
+  instanceOf = R.Binop(R.javascript.InstanceOf(), R.Parameter(Type::Any(), 0),
+                       R.HeapConstant(F.function));
+  dummy = R.Unop(R.javascript.ToObject(), instanceOf);
+  replacement = R.reduce(instanceOf);
+  CHECK(IrOpcode::IsPhiOpcode(replacement->opcode()));
+  CHECK_EQ(replacement, dummy->InputAt(0));
+  CHECK_NE(instanceOf, dummy->InputAt(0));
+
+  // Do not reduce if right-hand side is not a function constant.
+  instanceOf = R.Binop(R.javascript.InstanceOf(), R.Parameter(Type::Any(), 0),
+                       R.Parameter(Type::Function(), 0));
+  dummy = R.Unop(R.javascript.ToObject(), instanceOf);
+  replacement = R.reduce(instanceOf);
+  CHECK_EQ(replacement, instanceOf);
+  CHECK_EQ(instanceOf, dummy->InputAt(0));
+}
+
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8